Global orchestrator reconcileServices should look at desired state only #1957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… avoid adding multiple tasks. Signed-off-by: Dong Chen <dongluo.chen@docker.com>
|
Ping @aaronlehmann. |
Codecov Report
@@ Coverage Diff @@
## bump_v1.13.2 #1957 +/- ##
===============================================
- Coverage 60.26% 55.3% -4.96%
===============================================
Files 75 102 +27
Lines 11903 17116 +5213
===============================================
+ Hits 7173 9466 +2293
- Misses 3910 6498 +2588
- Partials 820 1152 +332Continue to review full report at Codecov.
|
|
LGTM |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Global orchestrator reconcileServices should look at desired state only to avoid creating multiple tasks.
Signed-off-by: Dong Chen dongluo.chen@docker.com