updater: Decrease default monitoring period #1967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The updater monitors a tasks after they start to make sure they don't fail immediately. The default time interval for this is 30s. However, this is a bit long for synchronous updates to wait. Reduce it to 5s. Users who would like a longer monitoring period should specify their own value, or ideally use a health check in the service definition. Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>
Codecov Report
@@ Coverage Diff @@
## master #1967 +/- ##
=========================================
+ Coverage 53.57% 54.48% +0.9%
=========================================
Files 109 108 -1
Lines 18897 18587 -310
=========================================
+ Hits 10125 10128 +3
+ Misses 7541 7235 -306
+ Partials 1231 1224 -7Continue to review full report at Codecov.
|
|
LGTM |
|
Looks fine to me. |
|
Should this impact performance at all, actually? |
|
It shouldn't really impact performance. The main user-visible impact is that "update state" will switch to "complete" 5 seconds after updating the last task (if all goes well), instead of 30 seconds after. Right now this is a relatively mundane detail, but the WIP PR I have open in docker that shows progress bars for updates makes it a much bigger deal. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The updater monitors a tasks after they start to make sure they don't
fail immediately. The default time interval for this is 30s. However,
this is a bit long for synchronous updates to wait. Reduce it to 5s.
Users who would like a longer monitoring period should specify their own
value, or ideally use a health check in the service definition.