allocator: Remove deleted networks from the unallocated set #2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This looks like an oversight. Networks may have been kept in this set forever after deletion. Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>
Codecov Report
@@ Coverage Diff @@
## master #2019 +/- ##
==========================================
+ Coverage 53.66% 53.69% +0.03%
==========================================
Files 109 109
Lines 18991 18992 +1
==========================================
+ Hits 10191 10198 +7
+ Misses 7578 7566 -12
- Partials 1222 1228 +6Continue to review full report at Codecov.
|
|
Looks good to me |
|
LGTM |
This was referenced Mar 10, 2017
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This looks like an oversight. Networks may have been kept in this set
forever after deletion.
cc @alexmavr @yongtang @aboch