-
-
Notifications
You must be signed in to change notification settings - Fork 157
support plugins with docsify init #98
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Comments
docsify init
You meant something like this ?
by |
yeah exactly! so if I do: docsify init docs/ -p docsify-themeable docsify-tabs docsify it would create those I guess options for plugins would mean restricting it to file based only (something like |
We cant support a config file for the CLI at this point as it would create an confusion for users as the html too has a config object. Though we can consider this PoC is Welcome for this |
sure I'll have a go |
Please ensure that docsify plugins versions are locked to the current major version to align with the work done here: #107 To be clear, we don't know the major version of third-party plugins so we can't lock those. I am only referring to plugins within the docsify repo. |
@jhildenbiddle I didnt get this ? Did you mean any compatibility issue? |
I mean the following plugins: https://cdn.jsdelivr.net/npm/docsify@4/lib/plugins/ ... are all maintained by the docsify team, stored in the same repo as docsify, and therefore designed to work with a specific version of docsify. If we add the ability to specify plugins using the CLI as mentioned above: docsify init docs/ -p external-script search We need to lock the plugins loaded to the same major version of docsify: <script src="//cdn.jsdelivr.net/npm/docsify@4/lib/plugins/external-script.min.js"></script>
<script src="//cdn.jsdelivr.net/npm/docsify@4/lib/plugins/search.min.js"></script> Also, I don't think we should tackle loading third-party plugins initially. That gets complicated quickly. For example:
Since the docsify team controls all of the plugins listed above, we know how to answer these questions. With third-party plugins we don't. We could, but it will require coordination with plugin/theme authors. |
I see, I did request the changes you mentioned. 👍 Also, we don't have to think about loading third-party plugins with respect to compatibility issues. |
Ahh. Didn’t realize there was a related PR in place. Thanks, @anikethsaha. Regarding the third party plugins, I only mentioned those because docsify-themeable and docsify-tabs were used as example in your example cli command:
If third-party plugins aren’t supported by the cli, then no worries. If they are (as the example above implies) then there are additional discussions that need to take place. |
Thats the same I thought , but looking at the PR, it is only implementing only core plugins. Though we can include third part as well. cc @tool3 |
Hi guys! To support 3rd party plugins which have a custom configuration, obviously this won't work since we don't handle this. But for 3rd party plugins which have default configurations - this should work 😃 |
Hi!
I have been using
docsify
for some of my projects, and I absolutely love it. even made a github-action out of it for the github action hackathon ;)I think support for being able to
init
adocs
directory with a list of plugins, maybe loaded from a predefined file or even through cli flags, would be so great, and it will better supportdocsify
in CI/CD.The text was updated successfully, but these errors were encountered: