Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Consider listing FifoCI build status in PR checks #6

Open
OatmealDome opened this issue Dec 10, 2023 · 0 comments
Open

Consider listing FifoCI build status in PR checks #6

OatmealDome opened this issue Dec 10, 2023 · 0 comments

Comments

@OatmealDome
Copy link
Member

Recently, we merged a PR that used some features from "unstable" ENet. Unfortunately, this meant that using system-provided ENet (which is usually on the latest release) when building Dolphin would cause a compilation error.

Because of this, FifoCI on some machines broke for several days. Because FifoCI only reports failures when Dolphin crashes while playing back a FIFO log, nobody noticed the failure.

If FifoCI build failures were listed in the PR checks, this wouldn't have happened.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Development

No branches or pull requests

1 participant