Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

dolt sql \commit uses static time stamp #8477

Open
macneale4 opened this issue Oct 22, 2024 · 1 comment
Open

dolt sql \commit uses static time stamp #8477

macneale4 opened this issue Oct 22, 2024 · 1 comment
Assignees
Labels

Comments

@macneale4
Copy link
Contributor

Recorded timestamp on commits performed in sql shell with \commit appear to be the time that dolt sql was started.

lcl:~/Documents/data_dir_1/db5$ dolt sql
# Welcome to the DoltSQL shell.
# Statements must be terminated with ';'.
# "exit" or "quit" (or Ctrl-D) to exit. "\help" for help.
db5/main> select current_time;
+--------------+
| current_time |
+--------------+
| 14:54:27     |
+--------------+
1 row in set (0.00 sec)

db5/main> \commit --allow-empty -m "commit"
commit dkge3b16mapfocpf5iarbs2atduc337v (HEAD -> main)
Author: macneale <neil@dolthub.com>
Date:  Tue Oct 22 14:54:26 -0700 2024

        commit

db5/main> select current_time;
+--------------+
| current_time |
+--------------+
| 14:54:37     |
+--------------+
1 row in set (0.00 sec)

db5/main> \commit --allow-empty -m "commit again"
commit hvtpfojmdnraq3fhovhhujf8pukmsmnj (HEAD -> main)
Author: macneale <neil@dolthub.com>
Date:  Tue Oct 22 14:54:26 -0700 2024

        commit again
@macneale4 macneale4 self-assigned this Oct 22, 2024
@macneale4
Copy link
Contributor Author

Also, doesn't seem to effect the stored procedure.

db5/main> call dolt_commit("--allow-empty","-m", "commit again");
+----------------------------------+
| hash                             |
+----------------------------------+
| fsqui9k22g6nhdlr41hga5niobh0ov6v |
+----------------------------------+
1 row in set (0.01 sec)

db5/main> \show
commit fsqui9k22g6nhdlr41hga5niobh0ov6v (HEAD -> main)
Author: root <root@localhost>
Date:  Tue Oct 22 15:14:34 -0700 2024

        commit again

db5/main> call dolt_commit("--allow-empty","-m", "commit again");
+----------------------------------+
| hash                             |
+----------------------------------+
| 57h9nhv4st28p18tbdjsvpnfl571vjhi |
+----------------------------------+
1 row in set (0.01 sec)

db5/main> \show
commit 57h9nhv4st28p18tbdjsvpnfl571vjhi (HEAD -> main)
Author: root <root@localhost>
Date:  Tue Oct 22 15:14:51 -0700 2024

        commit again

@timsehn timsehn added enhancement New feature or request cli version control labels Oct 23, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants