Skip to content
This repository has been archived by the owner on Dec 4, 2018. It is now read-only.

Not all jsonparse errors are handled by JSONStream #136

Open
ataube opened this issue Jul 5, 2017 · 1 comment · May be fixed by #138
Open

Not all jsonparse errors are handled by JSONStream #136

ataube opened this issue Jul 5, 2017 · 1 comment · May be fixed by #138

Comments

@ataube
Copy link

ataube commented Jul 5, 2017

The underlying jsonparse lib triggers one specific error which is not handled by JSONStream:
Look here:
https://github.com/creationix/jsonparse/blob/master/jsonparse.js#L321

And here:
https://github.com/dominictarr/JSONStream/blob/master/index.js#L140

It would be helpful if JSONStream could also wrap this error as an Invalid JSON message to have a consistent error contract one can check for.

@dominictarr
Copy link
Owner

sure, I would be happy to merge this pull request!

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants