Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Rename s3 stuff #715

Open
2 tasks
Godley opened this issue Jun 21, 2019 · 0 comments
Open
2 tasks

Rename s3 stuff #715

Godley opened this issue Jun 21, 2019 · 0 comments
Labels

Comments

@Godley
Copy link
Contributor

Godley commented Jun 21, 2019

Our s3transferrequest was based off of dotmesh's transfer request and as such includes some confusing entries.

  • RemoteName should be BucketName or BucketURL
  • Endpoint should be S3Endpoint (this is for testing only and I confused this with the above)

I haven't acted on this because we have weird parsing of structs going on and it might get tangled.

@Godley Godley added the debt label Jun 21, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant