You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Silk.NET.Vulkan.Extent2D and Silk.NET.Vulkan.Extent3D should implement IEquatable.
Comments
There might be other structs that would benefit from the implementation.
In my code I'm comparing 2 Silk.NET.Vulkan.Extent2D with currentSize.Equals(displaySize) to check if some resources should be recreated.
As a workaround i changed my code to compare the individual fields.
Output from resharper code inspection:
warning: Struct 'Extent2D' is checked for equality using the inefficient runtime-provided implementation
Default implementations of the 'Equals' and 'GetHashCode' methods of a struct are reflection-based and bad-performing
The text was updated successfully, but these errors were encountered:
Summary of feature
Silk.NET.Vulkan.Extent2D and Silk.NET.Vulkan.Extent3D should implement IEquatable.
Comments
There might be other structs that would benefit from the implementation.
In my code I'm comparing 2 Silk.NET.Vulkan.Extent2D with
currentSize.Equals(displaySize)
to check if some resources should be recreated.As a workaround i changed my code to compare the individual fields.
Output from resharper code inspection:
The text was updated successfully, but these errors were encountered: