Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Scalar.As to be generated by T4? #639

Closed
WhiteBlackGoose opened this issue Oct 16, 2021 · 4 comments · Fixed by #646
Closed

Scalar.As to be generated by T4? #639

WhiteBlackGoose opened this issue Oct 16, 2021 · 4 comments · Fixed by #646
Assignees
Labels
area-Maths enhancement New feature or request

Comments

@WhiteBlackGoose
Copy link
Contributor

Writing scalar as manually is quadratic complexity of free time 😆

@HurricanKai if I understand correctly, it's your area. What do you think?
Also wonder if we can generate other Scalar's methods with it

@WhiteBlackGoose WhiteBlackGoose added the enhancement New feature or request label Oct 16, 2021
@HurricanKai
Copy link
Member

Yeah, this is true. We could likely do this with T4, tough I just don't know much about T4.
I'd prefer using some helper program for other methods because they have specific Performance tuning changes made to them.
Scalar.As was originally written by @Perksey and I pretty much never touched it since.
If you want to change it to T4 or pretty much anything else I'm happy to merge that as well, it's uncommon to be touched so feel free to do whatever you like.

@WhiteBlackGoose
Copy link
Contributor Author

I definitely can do T4 (I use them in my prjs). The question is, how to make those cross-platform. There are some extensions, but I guess we need to make sure that those are available to any potential contributor?

@HurricanKai
Copy link
Member

Eeeeh, I think for Scalar.As it'd be fine regardless. As I said, it's pretty much never touched.

@WhiteBlackGoose
Copy link
Contributor Author

Gotcha. Then, assign it to me

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
area-Maths enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants