Skip to content

Commit 587805a

Browse files
committed
[ci] Don't convert Javadoc to Xmldoc for PR builds
Context: #5253 (comment) When Javadoc-to-Xmldoc conversion was enabled, `make jenkins` took 1h 19min 47sec, up from 34min 45sec (ouch!). Disable Javadoc-to-Xmldoc on PR builds. Hopefully `make jenkins` times will return to normal.
1 parent e972c3d commit 587805a

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

build-tools/automation/azure-pipelines.yaml

+1
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,7 @@ variables:
6767
DotNetNUnitCategories: '& TestCategory != DotNetIgnore & TestCategory != AOT & TestCategory != MkBundle & TestCategory != MonoSymbolicate & TestCategory != PackagesConfig & TestCategory != StaticProject & TestCategory != Debugger'
6868
NUnit.NumberOfTestWorkers: 4
6969
GitHub.Token: $(github--pat--vs-mobiletools-engineering-service2)
70+
CONVERT_JAVADOC_TO_XMLDOC: $[ne(variables['Build.DefinitionName'], 'Xamarin.Android-PR')]
7071

7172
# Stage and Job "display names" are shortened because they are combined to form the name of the corresponding GitHub check.
7273
stages:

src/Mono.Android/Mono.Android.csproj

+1-2
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,7 @@
2525
</PropertyGroup>
2626

2727
<PropertyGroup>
28-
<!-- TODO: Default to False; ~doubles the `make jenkins` build time -->
29-
<IncludeAndroidJavadoc Condition=" '$(IncludeAndroidJavadoc)' == '' And '$(AndroidFrameworkVersion)' == '$(AndroidLatestStableFrameworkVersion)'">True</IncludeAndroidJavadoc>
28+
<IncludeAndroidJavadoc Condition=" '$(IncludeAndroidJavadoc)' == '' And '$(CONVERT_JAVADOC_TO_XMLDOC)' == 'true' And '$(AndroidFrameworkVersion)' == '$(AndroidLatestStableFrameworkVersion)'">True</IncludeAndroidJavadoc>
3029
</PropertyGroup>
3130

3231
<PropertyGroup Condition=" '$(IncludeAndroidJavadoc)' == 'True' ">

0 commit comments

Comments
 (0)