Skip to content

Commit 8070717

Browse files
jonpryorjonpryor
committed
[Mono.Android] Generate Mono.Android.xml; @(JavaSourceJar) on JDK11
Fixes: #4789 Context: dotnet/java-interop#687 Context: #5200 What do we want? Updated documentation! How do we get that? Uh… Historically, [Xamarin.Android API docs][0] were produced by parsing Android's HTML documentation from `docs-24_r01.zip` and converting it into [**mdoc**(5) documentation][1] via [`tools/javadoc2mdoc`]. The problem is that Google hasn't released an updated `docs*.zip` package since API-24 (~6 years ago), and thus our documentation is woefully out of date. We could have scraped developer.android.com/reference within that time frame, but web scraping is annoying, and we'd still have to deal with the pain of parsing HTML. There is an alternative, though: with API-30, there is a new `sources` package which contains the Java source code used for the API level, which in turn contains Javadoc source code comments. Previous API levels similarly contained an `android-stubs-src.jar` file which likewise contained Java source code containing Javadoc comments. The new approach is to: 1. Update `build-tools/xaprepare` to install the `sources` package. 2. Use [`java-source-tool.jar`][2] to parse the Java source code, creating an `android-javadoc.xml` file. 3. [Update `generator`][3] to consume `android-javadoc.xml` and convert the Javadocs into [C# XML documentation comments][4]. 4. Update `src/Mono.Android` so that `generator` will emit C# XML doc comments, and then produce a `Mono.Android.xml` file. The result is a `Mono.Android.xml` file which contains imported Android Javadoc documentation, e.g. <doc> <assembly><name>Mono.Android</name></assembly> <members> <member name="T:Java.Lang.Object"> <summary>Class <c>Object</c> is the root of the class hierarchy.</summary> <remarks> <para>Class <c>Object</c> is the root of the class hierarchy. … "Later", `Mono.Android.xml` can then be used alongside [`mdoc update --import=Mono.Android.xml`][5] to update our published API documentation. Finally, commit 380e95e, which added support for JDK 11, *broke* support for `@(JavaSourceJar)` when running under JDK 11, as JDK 11's Javadoc HTML output differs from what we expect. With the new `java-source-utils.jar` and `generator --with-javadoc-xml=FILE` infrastructure in place, we can reasonably address this breakage under JDK 11, fixing Issue #4789: Update `Xamarin.Android.Bindings.Core.targets` so that before invoking `generator`, we first run `java-source-utils.jar` on the `@(JavaSourceJar)` files, producing Javadoc XML files. The `<BindingsGenerator/>` task in turn is updated to accept a new `BindingsGenerator.JavadocXml` property, which is converted into a `generator --with-javadoc-xml=FILE` option. The `@(JavaSourceJar)` item group is "extended" to support the following item metadata: * `%(CopyrightFile)`: A path to a file that contains copyright information for the Javadoc contents, which will be appended to all imported documentation. * `%(UrlPrefix)`: A URL prefix to support linking to online documentation within imported documentation. * `%(UrlStyle)`: The "style" of URLs to generate when linking to online documentation. Only one style is currently supported: `developer.android.com/reference@2020-Nov`. For .NET 6 ("One .NET") integration purposes, provide a default item group of `@(JavaSourceJar)` which includes `**\*-source?.jar` and `**\*-src.jar`. This will allow `dotnet build` of an "Android Java Library Binding" project (`dotnet new android-bindinglib`) to automatically process `.java` source code for documentation translation purposes. Finally, add `Java.Interop.Tools.Generator.dll` to the `Microsoft.Android.Sdk*.nupkg` file, as it is an assembly dependency of `generator.dll`. (Not sure why this didn't previously fail…) [0]: https://github.com/xamarin/android-api-docs [1]: http://docs.go-mono.com/?link=man%3amdoc(5) [2]: dotnet/java-interop@69e1b80 [3]: dotnet/java-interop#687 [4]: https://docs.microsoft.com/dotnet/csharp/codedoc [5]: http://docs.go-mono.com/?link=man%3amdoc-update(1)
1 parent e346f84 commit 8070717

File tree

19 files changed

+332
-36
lines changed

19 files changed

+332
-36
lines changed

‎.gitmodules

+2-2
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,8 @@
1212
branch = master
1313
[submodule "external/Java.Interop"]
1414
path = external/Java.Interop
15-
url = https://github.com/xamarin/java.interop.git
16-
branch = master
15+
url = https://github.com/jonpryor/java.interop.git
16+
branch = jonp-generator-javadoc-xml
1717
[submodule "external/lz4"]
1818
path = external/lz4
1919
url = https://github.com/lz4/lz4.git

‎Xamarin.Android.sln

+8-1
Original file line numberDiff line numberDiff line change
@@ -142,6 +142,8 @@ Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Xamarin.SourceWriter", "ext
142142
EndProject
143143
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "apksigner", "src\apksigner\apksigner.csproj", "{9A9EF774-6EA6-414F-9D2F-DCD66C56B92A}"
144144
EndProject
145+
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "java-source-utils", "external\Java.Interop\tools\java-source-utils\java-source-utils.csproj", "{37FCD325-1077-4603-98E7-4509CAD648D6}"
146+
EndProject
145147
Global
146148
GlobalSection(SharedMSBuildProjectFiles) = preSolution
147149
src\Xamarin.Android.NamingCustomAttributes\Xamarin.Android.NamingCustomAttributes.projitems*{3f1f2f50-af1a-4a5a-bedb-193372f068d7}*SharedItemsImports = 4
@@ -376,7 +378,7 @@ Global
376378
{071D9096-65BB-4359-822E-09788439F210}.Debug|AnyCPU.ActiveCfg = Debug|Any CPU
377379
{071D9096-65BB-4359-822E-09788439F210}.Debug|AnyCPU.Build.0 = Debug|Any CPU
378380
{071D9096-65BB-4359-822E-09788439F210}.Release|AnyCPU.ActiveCfg = Release|Any CPU
379-
{071D9096-65BB-4359-822E-09788439F210}.Release|AnyCPU.Build.0 = Release|Any CPU EndGlobalSection
381+
{071D9096-65BB-4359-822E-09788439F210}.Release|AnyCPU.Build.0 = Release|Any CPU
380382
{2CE4CD4B-B7B7-4EAE-A9BE-2699824D6096}.Debug|AnyCPU.ActiveCfg = Debug|Any CPU
381383
{2CE4CD4B-B7B7-4EAE-A9BE-2699824D6096}.Debug|AnyCPU.Build.0 = Debug|Any CPU
382384
{2CE4CD4B-B7B7-4EAE-A9BE-2699824D6096}.Release|AnyCPU.ActiveCfg = Release|Any CPU
@@ -389,6 +391,10 @@ Global
389391
{9A9EF774-6EA6-414F-9D2F-DCD66C56B92A}.Debug|AnyCPU.Build.0 = Debug|Any CPU
390392
{9A9EF774-6EA6-414F-9D2F-DCD66C56B92A}.Release|AnyCPU.ActiveCfg = Release|Any CPU
391393
{9A9EF774-6EA6-414F-9D2F-DCD66C56B92A}.Release|AnyCPU.Build.0 = Release|Any CPU
394+
{37FCD325-1077-4603-98E7-4509CAD648D6}.Debug|AnyCPU.ActiveCfg = Debug|Any CPU
395+
{37FCD325-1077-4603-98E7-4509CAD648D6}.Debug|AnyCPU.Build.0 = Debug|Any CPU
396+
{37FCD325-1077-4603-98E7-4509CAD648D6}.Release|AnyCPU.ActiveCfg = Release|Any CPU
397+
{37FCD325-1077-4603-98E7-4509CAD648D6}.Release|AnyCPU.Build.0 = Release|Any CPU
392398
EndGlobalSection
393399
GlobalSection(SolutionProperties) = preSolution
394400
HideSolutionNode = FALSE
@@ -454,6 +460,7 @@ Global
454460
{2CE4CD4B-B7B7-4EAE-A9BE-2699824D6096} = {04E3E11E-B47D-4599-8AFC-50515A95E715}
455461
{86A8DEFE-7ABB-4097-9389-C249581E243D} = {04E3E11E-B47D-4599-8AFC-50515A95E715}
456462
{9A9EF774-6EA6-414F-9D2F-DCD66C56B92A} = {04E3E11E-B47D-4599-8AFC-50515A95E715}
463+
{37FCD325-1077-4603-98E7-4509CAD648D6} = {864062D3-A415-4A6F-9324-5820237BA058}
457464
EndGlobalSection
458465
GlobalSection(ExtensibilityGlobals) = postSolution
459466
SolutionGuid = {53A1F287-EFB2-4D97-A4BB-4A5E145613F6}

‎build-tools/create-packs/Microsoft.Android.Sdk.proj

+1
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,7 @@ core workload sdk packs imported by Microsoft.NET.Workload.Android.
7676
<_PackageFiles Include="$(ToolsSourceDir)**" PackagePath="tools" />
7777
<_PackageFiles Include="$(NetCoreAppToolsSourceDir)generator.dll" PackagePath="tools" />
7878
<_PackageFiles Include="$(NetCoreAppToolsSourceDir)generator.runtimeconfig.json" PackagePath="tools" />
79+
<_PackageFiles Include="$(NetCoreAppToolsSourceDir)Java.Interop.Tools.Generator.dll" PackagePath="tools" />
7980
<_PackageFiles Include="$(NetCoreAppToolsSourceDir)javadoc-to-mdoc.dll" PackagePath="tools" />
8081
<_PackageFiles Include="$(NetCoreAppToolsSourceDir)javadoc-to-mdoc.runtimeconfig.json" PackagePath="tools" />
8182
<_PackageFiles Include="$(XAInstallPrefix)xbuild-frameworks\Microsoft.Android\Version*" PackagePath="tools" />

‎build-tools/installers/create-installers.targets

+3
Original file line numberDiff line numberDiff line change
@@ -132,6 +132,7 @@
132132
<_MSBuildFiles Include="$(MSBuildSrcDir)\illinkanalyzer.pdb" ExcludeFromAndroidNETSdk="true" />
133133
<_MSBuildFiles Include="$(MSBuildSrcDir)\Irony.dll" />
134134
<_MSBuildFiles Include="$(MSBuildSrcDir)\java-interop.jar" />
135+
<_MSBuildFiles Include="$(MSBuildSrcDir)\java-source-utils.jar" />
135136
<_MSBuildFiles Include="$(MSBuildSrcDir)\javadoc-to-mdoc.exe" ExcludeFromAndroidNETSdk="true" />
136137
<_MSBuildFiles Include="$(MSBuildSrcDir)\javadoc-to-mdoc.pdb" ExcludeFromAndroidNETSdk="true" />
137138
<_MSBuildFiles Include="$(MSBuildSrcDir)\Java.Interop.dll" />
@@ -149,6 +150,8 @@
149150
<_MSBuildFiles Include="$(MSBuildSrcDir)\Java.Interop.Tools.Generator.pdb" ExcludeFromAndroidNETSdk="true" />
150151
<_MSBuildFiles Include="$(MSBuildSrcDir)\Java.Interop.Tools.JavaCallableWrappers.dll" />
151152
<_MSBuildFiles Include="$(MSBuildSrcDir)\Java.Interop.Tools.JavaCallableWrappers.pdb" />
153+
<_MSBuildFiles Include="$(MSBuildSrcDir)\Java.Interop.Tools.JavaSource.dll" />
154+
<_MSBuildFiles Include="$(MSBuildSrcDir)\Java.Interop.Tools.JavaSource.pdb" />
152155
<_MSBuildFiles Include="$(MSBuildSrcDir)\Java.Runtime.Environment.dll" />
153156
<_MSBuildFiles Include="$(MSBuildSrcDir)\Java.Runtime.Environment.pdb" />
154157
<_MSBuildFiles Include="$(MSBuildSrcDir)\Java.Runtime.Environment.dll.config" Condition=" '$(HostOS)' != 'Windows' " />

‎build-tools/xaprepare/xaprepare/ConfigAndData/Dependencies/AndroidToolchain.cs

+2
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,8 @@ public AndroidToolchain ()
6262
new AndroidPlatformComponent ("platform-29_r01", apiLevel: "29", pkgRevision: "1"),
6363
new AndroidPlatformComponent ("platform-30_r01", apiLevel: "30", pkgRevision: "1"),
6464

65+
new AndroidToolchainComponent ("sources-30_r01", destDir: Path.Combine ("platforms", $"android-30", "src"), pkgRevision: "1", dependencyType: AndroidToolchainComponentType.BuildDependency),
66+
6567
new AndroidToolchainComponent ("docs-24_r01", destDir: "docs", pkgRevision: "1", dependencyType: AndroidToolchainComponentType.BuildDependency),
6668
new AndroidToolchainComponent ("android_m2repository_r47", destDir: Path.Combine ("extras", "android", "m2repository"), pkgRevision: "47.0.0", dependencyType: AndroidToolchainComponentType.BuildDependency),
6769
new AndroidToolchainComponent ($"x86_64-29_r07-{osTag}", destDir: Path.Combine ("system-images", "android-29", "default", "x86_64"), relativeUrl: new Uri ("sys-img/android/", UriKind.Relative), pkgRevision: "7", dependencyType: AndroidToolchainComponentType.EmulatorDependency),

‎build-tools/xaprepare/xaprepare/ThirdPartyNotices/Java.Interop.cs

+13
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ class JavaInterop_External_Dependencies_Group : ThirdPartyNoticeGroup
1212
public override List<ThirdPartyNotice> Notices => new List <ThirdPartyNotice> {
1313
new JavaInterop_xamarin_Java_Interop_TPN (),
1414
new JavaInterop_gityf_crc_TPN (),
15+
new JavaInterop_javaparser_javaparser_TPN (),
1516
new JavaInterop_jbevain_mono_linq_expressions_TPN (),
1617
new JavaInterop_mono_csharp_TPN (),
1718
new JavaInterop_mono_LineEditor_TPN (),
@@ -69,6 +70,18 @@ POSSIBILITY OF SUCH DAMAGE.
6970
";
7071
}
7172

73+
// via: https://github.com/xamarin/java.interop/blob/b588ef502d8d3b4c32e0ad731115e1b71fd56b5c/tools/java-source-utils/build.gradle#L33-L34
74+
class JavaInterop_javaparser_javaparser_TPN : ThirdPartyNotice
75+
{
76+
static readonly Uri url = new Uri ("https://github.com/javaparser/javaparser/");
77+
static readonly string licenseFile = Path.Combine (Configurables.Paths.ExternalJavaInteropDir, "LICENSE");
78+
79+
public override string LicenseFile => CommonLicenses.Apache20Path;
80+
public override string Name => "javaparser/javaparser";
81+
public override Uri SourceUrl => url;
82+
public override string LicenseText => String.Empty;
83+
}
84+
7285
// git submodules of Java.Interop
7386
class JavaInterop_jbevain_mono_linq_expressions_TPN : ThirdPartyNotice
7487
{

‎external/Java.Interop

Submodule Java.Interop updated 37 files

‎src/Mono.Android/Mono.Android.csproj

+11
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,16 @@
2424
<ProduceReferenceAssembly>true</ProduceReferenceAssembly>
2525
</PropertyGroup>
2626

27+
<PropertyGroup>
28+
<!-- TODO: Default to False; ~doubles the `make jenkins` build time -->
29+
<IncludeAndroidJavadoc Condition=" '$(IncludeAndroidJavadoc)' == '' And '$(AndroidFrameworkVersion)' == '$(AndroidLatestStableFrameworkVersion)'">True</IncludeAndroidJavadoc>
30+
</PropertyGroup>
31+
32+
<PropertyGroup Condition=" '$(IncludeAndroidJavadoc)' == 'True' ">
33+
<DocumentationFile>$(OutputPath)Mono.Android.xml</DocumentationFile>
34+
<NoWarn>CS1573;CS1591</NoWarn>
35+
</PropertyGroup>
36+
2737
<PropertyGroup Condition=" '$(TargetFramework)' == 'monoandroid10' ">
2838
<TargetFrameworkIdentifier>MonoAndroid</TargetFrameworkIdentifier>
2939
<TargetFrameworkVersion>v1.0</TargetFrameworkVersion>
@@ -345,6 +355,7 @@
345355
<ProjectReference Include="..\..\build-tools\api-merge\api-merge.csproj" ReferenceOutputAssembly="false" SkipGetTargetFrameworkProperties="true" AdditionalProperties="TargetFramework=net472" />
346356
<ProjectReference Include="..\..\build-tools\jnienv-gen\jnienv-gen.csproj" ReferenceOutputAssembly="false" SkipGetTargetFrameworkProperties="true" AdditionalProperties="TargetFramework=net472" />
347357
<ProjectReference Include="..\..\external\Java.Interop\tools\generator\generator.csproj" ReferenceOutputAssembly="false" SkipGetTargetFrameworkProperties="true" AdditionalProperties="TargetFramework=net472"/>
358+
<ProjectReference Include="..\..\external\Java.Interop\tools\java-source-utils\java-source-utils.csproj" ReferenceOutputAssembly="false" SkipGetTargetFrameworkProperties="true" AdditionalProperties="TargetFramework=net472" />
348359
<ProjectReference Include="..\..\external\Java.Interop\tools\jcw-gen\jcw-gen.csproj" ReferenceOutputAssembly="false" SkipGetTargetFrameworkProperties="true" AdditionalProperties="TargetFramework=net472" />
349360
<ProjectReference Include="..\..\src\java-runtime\java-runtime.csproj" ReferenceOutputAssembly="false" />
350361
<ProjectReference Include="..\r8\r8.csproj" ReferenceOutputAssembly="False" />

‎src/Mono.Android/Mono.Android.targets

+47-1
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,50 @@
5353
Replacements="@PACKAGE_VERSION@=$(_PackageVersion);@PACKAGE_VERSION_BUILD@=$(_PackageVersionBuild);@PACKAGE_HEAD_REV@=$(XAVersionHash);@PACKAGE_HEAD_BRANCH@=$(XAVersionBranch)">
5454
</ReplaceFileContents>
5555
</Target>
56+
<PropertyGroup>
57+
<_JavaSourceUtilsJar>$(XAInstallPrefix)xbuild\Xamarin\Android\java-source-utils.jar</_JavaSourceUtilsJar>
58+
<_AndroidStableSrcDir>$(AndroidSdkDirectory)\platforms\android-$(AndroidLatestStableApiLevel)\src</_AndroidStableSrcDir>
59+
<_AndroidJavadocXml>..\..\bin\Build$(Configuration)\android-javadoc.xml</_AndroidJavadocXml>
60+
</PropertyGroup>
61+
<Target Name="_BuildAndroidJavadocXml"
62+
Condition=" '$(IncludeAndroidJavadoc)' == 'True' "
63+
BeforeTargets="CoreCompile"
64+
Inputs="$(MSBuildThisFile);$(_AndroidStableSrcDir)\source.properties;$(_JavaSourceUtilsJar)"
65+
Outputs="$(_AndroidJavadocXml)">
66+
<ItemGroup>
67+
<_Doclink Include="--doc-copyright" />
68+
<_Doclink Include="$(MSBuildThisFileDirectory)javadoc-copyright.xml" />
69+
<_Doclink Include="--doc-url-prefix" />
70+
<_Doclink Include="https://developer.android.com/reference" />
71+
<_Doclink Include="--doc-url-style" />
72+
<_Doclink Include="developer.android.com/reference@2020-Nov" />
73+
</ItemGroup>
74+
<ItemGroup>
75+
<_AndroidSources Include="$(_AndroidStableSrcDir)\android\**\*.java" />
76+
<_AndroidSources Include="$(_AndroidStableSrcDir)\java\**\*.java" />
77+
<_AndroidSources Include="$(_AndroidStableSrcDir)\javax\**\*.java" />
78+
<_AndroidSources Include="$(_AndroidStableSrcDir)\org\**\*.java" />
79+
<_AndroidSources Remove="$(_AndroidStableSrcDir)\**\*.annotated.java" />
80+
</ItemGroup>
81+
<PropertyGroup>
82+
<_Filenames>$(IntermediateOutputPath)\java-sources.txt</_Filenames>
83+
</PropertyGroup>
84+
<WriteLinesToFile
85+
File="$(_Filenames)"
86+
Lines="@(_Doclink);@(_AndroidSources)"
87+
Overwrite="True"
88+
/>
89+
<ItemGroup>
90+
<_JSIArg Include="-v" />
91+
<_JSIArg Include="--source &quot;$(_AndroidStableSrcDir)&quot;" />
92+
<_JSIArg Include="--output-javadoc &quot;$(_AndroidJavadocXml)&quot;" />
93+
<_JSIArg Include="@$(_Filenames)" />
94+
</ItemGroup>
95+
<Exec
96+
Command="&quot;$(JavaPath)&quot; -jar &quot;$(_JavaSourceUtilsJar)&quot; @(_JSIArg, ' ')"
97+
/>
98+
<Touch Files="$(_AndroidJavadocXml)" />
99+
</Target>
56100
<Target Name="_BuildJNIEnv"
57101
BeforeTargets="CoreCompile"
58102
Inputs="..\..\bin\Build$(Configuration)\jnienv-gen.exe"
@@ -113,12 +157,14 @@
113157
<_TypeMap>--type-map-report=$(IntermediateOutputPath)mcw\type-mapping.txt</_TypeMap>
114158
<_Api>$(IntermediateOutputPath)mcw\api.xml</_Api>
115159
<_Dirs>--enumdir=$(IntermediateOutputPath)mcw</_Dirs>
160+
<_WithJavadocXml Condition=" '$(IncludeAndroidJavadoc)' == 'True' ">"--with-javadoc-xml=$(_AndroidJavadocXml)"</_WithJavadocXml>
116161
<_FullIntermediateOutputPath>$([System.IO.Path]::GetFullPath('$(IntermediateOutputPath)'))</_FullIntermediateOutputPath>
117162
<_LangFeatures>--lang-features=nullable-reference-types</_LangFeatures>
118163
<_LangFeatures Condition="$(AndroidApiLevel) &gt;= 30">$(_LangFeatures),default-interface-methods,nested-interface-types,interface-constants</_LangFeatures>
119164
</PropertyGroup>
120165
<Exec
121-
Command="$(ManagedRuntime) $(ManagedRuntimeArgs) $(Generator) $(_GenFlags) $(_ApiLevel) $(_Out) $(_Codegen) $(_Fixup) $(_Enums1) $(_Enums2) $(_Versions) $(_Annotations) $(_Assembly) $(_TypeMap) $(_LangFeatures) $(_Dirs) $(_Api)"
166+
Command="$(ManagedRuntime) $(ManagedRuntimeArgs) $(Generator) $(_GenFlags) $(_ApiLevel) $(_Out) $(_Codegen) $(_Fixup) $(_Enums1) $(_Enums2) $(_Versions) $(_Annotations) $(_Assembly) $(_TypeMap) $(_LangFeatures) $(_Dirs) $(_Api) $(_WithJavadocXml)"
167+
IgnoreStandardErrorWarningFormat="True"
122168
/>
123169
<ItemGroup>
124170
<Compile Include="$(_FullIntermediateOutputPath)\mcw\**\*.cs" KeepDuplicates="False" />

‎src/Mono.Android/javadoc-copyright.xml

+5
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
<para>Portions of this page are modifications based on work created and shared by the <format type="text/html">
2+
<a href="https://developers.google.com/terms/site-policies" title="Android Open Source Project">Android Open Source Project</a>
3+
</format> and used according to terms described in the <format type="text/html">
4+
<a href="https://creativecommons.org/licenses/by/2.5/" title="Creative Commons 2.5 Attribution License">Creative Commons 2.5 Attribution License.</a></format>
5+
</para>

‎src/Xamarin.Android.Build.Tasks/MSBuild/Xamarin/Android/Xamarin.Android.Bindings.Core.targets

+28-1
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ It is shared between "legacy" binding projects and .NET 5 projects.
1212
<Project xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
1313

1414
<UsingTask TaskName="Xamarin.Android.Tasks.BindingsGenerator" AssemblyFile="Xamarin.Android.Build.Tasks.dll" />
15+
<UsingTask TaskName="Xamarin.Android.Tasks.JavaSourceUtils" AssemblyFile="Xamarin.Android.Build.Tasks.dll" />
1516
<UsingTask TaskName="Xamarin.Android.Tasks.RemoveDirFixed" AssemblyFile="Xamarin.Android.Build.Tasks.dll" />
1617

1718
<PropertyGroup>
@@ -21,6 +22,11 @@ It is shared between "legacy" binding projects and .NET 5 projects.
2122
<_GeneratorStampFile>$(IntermediateOutputPath)generator.stamp</_GeneratorStampFile>
2223
</PropertyGroup>
2324

25+
<PropertyGroup Condition=" '$(_UseLegacyJavadocImport' != 'True' ">
26+
<DocumentationFile Condition=" '$(DocumentationFile)' == '' ">$(OutputPath)\$(AssemblyName).xml</DocumentationFile>
27+
<NoWarn Condition=" '$(DocumentationFile)' != '' ">$(NoWarn);CS1573;CS1591</NoWarn>
28+
</PropertyGroup>
29+
2430
<!-- Get our Build Actions to show up in VS -->
2531
<ItemGroup>
2632
<AvailableItemName Include="EmbeddedJar" />
@@ -38,7 +44,11 @@ It is shared between "legacy" binding projects and .NET 5 projects.
3844

3945
<Target Name="ExportJarToXml"
4046
DependsOnTargets="$(ExportJarToXmlDependsOnTargets)"
41-
Condition=" '$(UsingAndroidNETSdk)' != 'true' Or '@(InputJar->Count())' != '0' Or '@(EmbeddedJar->Count())' != '0' Or '@(LibraryProjectZip->Count())' != '0' ">
47+
Condition=" '$(_UseLegacyJavadocImport)' == 'True' And
48+
('$(UsingAndroidNETSdk)' != 'true' Or
49+
'@(InputJar->Count())' != '0' Or
50+
'@(EmbeddedJar->Count())' != '0' Or
51+
'@(LibraryProjectZip->Count())' != '0') ">
4252
<PropertyGroup>
4353
<AllowUnsafeBlocks Condition=" '$(AllowUnsafeBlocks)' != 'true' ">true</AllowUnsafeBlocks>
4454
</PropertyGroup>
@@ -57,6 +67,22 @@ It is shared between "legacy" binding projects and .NET 5 projects.
5767
<AnnotationsZip Include="$(IntermediateOutputPath)library_project_annotations\**\*.zip" />
5868
</ItemGroup>
5969

70+
<JavaSourceUtils
71+
Condition=" '$(_UseLegacyJavadocImport)' != 'True' And '@(JavaSourceJar->Count())' != '0' "
72+
ContinueOnError="True"
73+
InputFiles="@(JavaSourceJar)"
74+
JavadocCopyrightFile="%(JavaSourceJar.CopyrightFile)"
75+
JavadocUrlPrefix="%(JavaSourceJar.UrlPrefix)"
76+
JavadocUrlStyle="%(JavaSourceJar.UrlStyle)"
77+
JavaMaximumHeapSize="$(JavaMaximumHeapSize)"
78+
JavaOptions="$(JavaOptions)"
79+
JavaSdkDirectory="$(_JavaSdkDirectory)"
80+
MonoAndroidToolsDirectory="$(MonoAndroidToolsDirectory)"
81+
OutputDirectory="$(GeneratedOutputPath)docs"
82+
References="">
83+
<Output TaskParameter="OutputJavadocXml" ItemName="_JavadocXml" />
84+
</JavaSourceUtils>
85+
6086
<!-- Create the .cs binding source files -->
6187
<BindingsGenerator
6288
OutputDirectory="$(GeneratedOutputPath)src"
@@ -67,6 +93,7 @@ It is shared between "legacy" binding projects and .NET 5 projects.
6793
ApiXmlInput="$(ApiOutputFile)"
6894
AnnotationsZipFiles="@(AnnotationsZip)"
6995
AssemblyName="$(AssemblyName)"
96+
JavadocXml="@(_JavadocXml)"
7097
TransformFiles="@(TransformFile)"
7198
ReferencedManagedLibraries="@(ReferencePath);@(ReferenceDependencyPaths)"
7299
MonoAndroidFrameworkDirectories="$(_XATargetFrameworkDirectories)"

‎src/Xamarin.Android.Build.Tasks/MSBuild/Xamarin/Android/Xamarin.Android.Bindings.Documentation.targets

+1-1
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ This file is only used by binding projects. .NET 5 can eventually use it, once `
3535
</Target>
3636

3737
<Target Name="_GenerateJavaDocFromSourceJars"
38-
Condition=" '$(_JavadocSupported)' == 'True' "
38+
Condition=" '$(_HaveJavaSourceUtils)' != 'True' And '$(_JavadocSupported)' == 'True' "
3939
Inputs="@(JavaSourceJar)"
4040
Outputs="@(JavaSourceJar->'$(IntermediateOutputPath)javadocs\%(FileName).stamp')">
4141
<Unzip

‎src/Xamarin.Android.Build.Tasks/Microsoft.Android.Sdk/Sdk/AutoImport.props

+2-1
Original file line numberDiff line numberDiff line change
@@ -33,9 +33,10 @@ https://github.com/dotnet/designs/blob/4703666296f5e59964961464c25807c727282cae/
3333
<!-- Default XPath transforms for bindings -->
3434
<TransformFile Include="Transforms\**\*.xml" />
3535
<!-- Default Java or native libraries -->
36-
<AndroidLibrary Include="**\*.jar" Exclude="$(DefaultItemExcludes);$(DefaultExcludesInProjectFolder)" />
36+
<AndroidLibrary Include="**\*.jar" Exclude="$(DefaultItemExcludes);$(DefaultExcludesInProjectFolder);**\*-source?.jar;**\*-src.jar" />
3737
<AndroidLibrary Include="**\*.aar" Exclude="$(DefaultItemExcludes);$(DefaultExcludesInProjectFolder)" />
3838
<AndroidNativeLibrary Include="**\*.so" Exclude="$(DefaultItemExcludes);$(DefaultExcludesInProjectFolder)" />
39+
<JavaSourceJar Include="**\*-source?.jar;**\*-src.jar" Exclude="$(DefaultItemExcludes);$(DefaultExcludesInProjectFolder)" />
3940
</ItemGroup>
4041

4142
</Project>

‎src/Xamarin.Android.Build.Tasks/Tasks/Generator.cs

+8
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,8 @@ public class BindingsGenerator : AndroidDotnetToolTask
5252
public ITaskItem[] ReferencedManagedLibraries { get; set; }
5353
public ITaskItem[] AnnotationsZipFiles { get; set; }
5454

55+
public ITaskItem[] JavadocXml { get; set; }
56+
5557
private List<Tuple<string, string>> transform_files = new List<Tuple<string,string>> ();
5658

5759
public override bool RunTask ()
@@ -166,6 +168,12 @@ protected override string GenerateCommandLineCommands ()
166168

167169
if (EnableInterfaceMembersPreview && SupportsCSharp8)
168170
WriteLine (sw, "--lang-features=interface-constants,default-interface-methods");
171+
172+
if (JavadocXml != null) {
173+
foreach (var xml in JavadocXml) {
174+
WriteLine (sw, $"--with-javadoc-xml=\"{Path.GetFullPath (xml.ItemSpec)}\"");
175+
}
176+
}
169177
}
170178

171179
cmd.AppendSwitch (ApiXmlInput);

0 commit comments

Comments
 (0)