From ef3e7ce4e0df53930acb02c056f9d03efe9af8e5 Mon Sep 17 00:00:00 2001 From: Jonathan Peppers Date: Wed, 1 Mar 2023 13:00:02 -0600 Subject: [PATCH] [build] pass `--skip-sign-check` to `dotnet workload` (#7840) Context: https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=7397299&view=logs&j=28f7b402-0b52-5743-3f46-b0c973acb4f8&t=06392762-0cbe-5837-5fae-a131d329206a&l=81 Context: 978b74f69ec049317501bd58f1f4a9073d13db46 Many times on release branches, parts of the .NET installer are signed, and we need to allow unsigned workloads to be installed via the `--skip-sign-check` flag: Rolling back pack Microsoft.Android.Sdk.Windows installation... Workload installation failed: Failed to validate package signing. Verifying Microsoft.Android.Sdk.Windows.34.0.0-ci.darc-release-8-0-1xx-preview2-cef50a92-f62d-4147-9b74-08689588cab8.180 This is testing a local build of the `android` workload, so it will not be signed at this stage. Let's put this change in main, so we don't have to keep doing this release branches. --- build-tools/create-packs/Directory.Build.targets | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/build-tools/create-packs/Directory.Build.targets b/build-tools/create-packs/Directory.Build.targets index 8cb06e245c0..ff6d4f99933 100644 --- a/build-tools/create-packs/Directory.Build.targets +++ b/build-tools/create-packs/Directory.Build.targets @@ -129,6 +129,7 @@ <_InstallArguments Include="android" /> <_InstallArguments Include="android-$(AndroidLatestUnstableApiLevel)" Condition=" '@(_PreviewPacks->Count())' != '0' " /> <_InstallArguments Include="--skip-manifest-update" /> + <_InstallArguments Include="--skip-sign-check" /> <_InstallArguments Include="--verbosity diag" /> <_InstallArguments Include="--source "%(_NuGetSources.Identity)"" /> <_InstallArguments Include="--temp-dir "$(_TempDirectory)"" /> @@ -278,7 +279,7 @@ Overwrite="true" />