Skip to content
This repository has been archived by the owner on Nov 1, 2020. It is now read-only.

Error on tests/runtest.sh -coreclr All #8362

Open
Rattenkrieg opened this issue Oct 10, 2020 · 3 comments
Open

Error on tests/runtest.sh -coreclr All #8362

Rattenkrieg opened this issue Oct 10, 2020 · 3 comments

Comments

@Rattenkrieg
Copy link
Contributor

Tested on Fedora 32, as per runtest.cmd should affect Windows as well.
On "all" selection -test_filter_path parameter for tests/CoreCLR/runtest.py is omitted and we getting into this branch:

if test_filter_path is None:
os.environ["__Exclude"] = os.path.join(coreclr_repo_location, "tests", "issues.targets")

There is no tests/issues.targets file. Probably this one meant to be used but somehow wasn't added. Git history gives no clue.
I see this wasn't detected because tests/runtest.sh -coreclr defaults to Top200.

@MichalStrehovsky
Copy link
Member

I don't think anyone ran all CoreCLR Pri-0 tests on Linux before.

We're in the process of migrating the repo to dotnet/runtimelab where we will use the same test runner as CoreCLR. Most of it should already work, but haven't looked at failures yet.

Why are you interested in running these?

@Rattenkrieg
Copy link
Contributor Author

Why are you interested in running these?

Wanted to contribue, I guess I have fix for #8246 and now looking to test it properly.
Btw I borrowed issues.targets from CoreCLR and had really hot ~90 mins running it. I never thought I would want swap partition enabled until my Firefox and VsCode were killed during test run. Most of the tests have failed for obvious reasons.

@MichalStrehovsky
Copy link
Member

Running all the tests only adds marginal value over what we enable in the CI - if you have something, we would be happy for a pull request!

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants