Skip to content

Commit 1a029ce

Browse files
committed
Re-enable xUnit analyzers
Resolves #22230
1 parent 43a5493 commit 1a029ce

File tree

4 files changed

+6
-16
lines changed

4 files changed

+6
-16
lines changed

test/Directory.Build.targets

-10
This file was deleted.

test/EFCore.Proxies.Tests/ChangeDetectionProxyTests.cs

+4-4
Original file line numberDiff line numberDiff line change
@@ -50,8 +50,8 @@ public void Does_not_throw_when_non_virtual_indexer_not_mapped()
5050
{
5151
using var context = new ChangeContext<ChangeNonVirtualIndexerNotUsed>();
5252

53-
Assert.False(
54-
context.Model.FindEntityType(typeof(ChangeNonVirtualIndexerNotUsed)).GetProperties().Any(e => e.IsIndexerProperty()));
53+
Assert.DoesNotContain(
54+
context.Model.FindEntityType(typeof(ChangeNonVirtualIndexerNotUsed)).GetProperties(), e => e.IsIndexerProperty());
5555
}
5656

5757
[ConditionalFact]
@@ -318,7 +318,7 @@ public void Raises_changing_event_when_equal_and_check_equality_false(bool useLa
318318
private class ChangeContext<TEntity> : TestContext<TEntity>
319319
where TEntity : class
320320
{
321-
private Action<EntityTypeBuilder<TEntity>> _entityBuilderAction;
321+
private readonly Action<EntityTypeBuilder<TEntity>> _entityBuilderAction;
322322

323323
public ChangeContext(
324324
bool useLazyLoading = false,
@@ -343,7 +343,7 @@ protected override void OnModelCreating(ModelBuilder modelBuilder)
343343
private class SharedChangeContext<TEntity> : DbContext
344344
where TEntity : class
345345
{
346-
private Action<EntityTypeBuilder<TEntity>> _entityBuilderAction;
346+
private readonly Action<EntityTypeBuilder<TEntity>> _entityBuilderAction;
347347

348348
public SharedChangeContext(Action<EntityTypeBuilder<TEntity>> entityBuilderAction = null)
349349
{

test/EFCore.Relational.Tests/Migrations/Internal/MigrationsModelDifferTest.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -337,7 +337,7 @@ public void Model_differ_breaks_double_foreign_key_cycles_in_create_table_operat
337337

338338
var createBankTableOperation = Assert.IsType<CreateTableOperation>(result[0]);
339339
Assert.Equal("Banks", createBankTableOperation.Name);
340-
Assert.Equal(0, createBankTableOperation.ForeignKeys.Count);
340+
Assert.Empty(createBankTableOperation.ForeignKeys);
341341

342342
Assert.Equal(4, result.OfType<AddForeignKeyOperation>().Count());
343343
});

test/EFCore.SqlServer.FunctionalTests/Query/QueryBugsTest.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -9310,7 +9310,7 @@ public virtual void Query_filter_with_contains_evaluates_correctly()
93109310
{
93119311
using var context = new MyContext10295(_options);
93129312
var result = context.Entities.ToList();
9313-
Assert.Equal(1, result.Count);
9313+
Assert.Single(result);
93149314

93159315
AssertSql(
93169316
@"SELECT [e].[Id], [e].[Name]

0 commit comments

Comments
 (0)