Add designTime parameter to IRelationalAnnotationProvider

Remove more design-time metadata from runtime model
Fix some configuration loss when reattaching entity types
Add missing SqlServer Metadata methods
Add more tests

Author: AndriySvyryd

src/EFCore.Design/Design/DesignTimeServiceCollectionExtensions.cs

@@ -58,7 +58,7 @@ public static IServiceCollection AddEntityFrameworkDesignTimeServices(
                     .TryAddSingleton<IMigrationsCodeGeneratorSelector, MigrationsCodeGeneratorSelector>()
                     .TryAddSingleton<IModelCodeGenerator, CSharpModelGenerator>()
                     .TryAddSingleton<IModelCodeGeneratorSelector, ModelCodeGeneratorSelector>()
-                    .TryAddSingleton<ICompiledModelCodeGenerator, CSharpSlimModelCodeGenerator>()
+                    .TryAddSingleton<ICompiledModelCodeGenerator, CSharpRuntimeModelCodeGenerator>()
                     .TryAddSingleton<ICompiledModelCodeGeneratorSelector, CompiledModelCodeGeneratorSelector>()
                     .TryAddSingleton<INamedConnectionStringResolver>(
                         new DesignTimeConnectionStringResolver(applicationServiceProviderAccessor))

src/EFCore.Design/Design/Internal/CSharpHelper.cs

@@ -24,17 +24,17 @@ namespace Microsoft.EntityFrameworkCore.Design.Internal
     /// </summary>
     public class CSharpHelper : ICSharpHelper
     {
-        private readonly IRelationalTypeMappingSource _relationalTypeMappingSource;
+        private readonly ITypeMappingSource _typeMappingSource;
 
         /// <summary>
         ///     This is an internal API that supports the Entity Framework Core infrastructure and not subject to
         ///     the same compatibility standards as public APIs. It may be changed or removed without notice in
         ///     any release. You should only use it directly in your code with extreme caution and knowing that
         ///     doing so can result in application failures when updating to a new Entity Framework Core release.
         /// </summary>
-        public CSharpHelper(IRelationalTypeMappingSource relationalTypeMappingSource)
+        public CSharpHelper(ITypeMappingSource typeMappingSource)
         {
-            _relationalTypeMappingSource = relationalTypeMappingSource;
+            _typeMappingSource = typeMappingSource;
         }
 
         private static readonly IReadOnlyCollection<string> _keywords = new[]
@@ -267,8 +267,13 @@ private static StringBuilder ChangeFirstLetterCase(StringBuilder builder, bool c
             }
 
             var first = builder[index: 0];
+            if (char.IsUpper(first) == capitalize)
+            {
+                return builder;
+            }
+
             builder.Remove(startIndex: 0, length: 1)
-                .Insert(index: 0, value: capitalize ? char.ToUpper(first) : char.ToLower(first));
+                .Insert(index: 0, value: capitalize ? char.ToUpperInvariant(first) : char.ToLowerInvariant(first));
 
             return builder;
         }
@@ -788,12 +793,17 @@ public virtual string UnknownLiteral(object? value)
                 return Literal(enumValue);
             }
 
+            if (value is Type type)
+            {
+                return Literal(type);
+            }
+
             if (value is Array array)
             {
                 return Array(literalType.GetElementType()!, array);
             }
 
-            var mapping = _relationalTypeMappingSource.FindMapping(literalType);
+            var mapping = _typeMappingSource.FindMapping(literalType);
             if (mapping != null)
             {
                 var builder = new StringBuilder();

src/EFCore.Design/Properties/DesignStrings.Designer.cs

@@ -133,7 +133,7 @@
     <value>Could not find type mapping for column '{columnName}' with data type '{dateType}'. Skipping column.</value>
   </data>
   <data name="CompiledModelConstructorBinding" xml:space="preserve">
-    <value>The entity type '{entityType}' has a custom constructor binding. This is usually caused by using proxies. Compiled model can't be generated, because custom constructor bindings are not supported.</value>
+    <value>The entity type '{entityType}' has a custom constructor binding. This is usually caused by using proxies. Compiled model can't be generated, because dynamic proxy types are not supported. If you are not using proxies configure the custom constructor binding in '{customize}' in a partial '{className}' class instead.</value>
   </data>
   <data name="CompiledModelDefiningQuery" xml:space="preserve">
     <value>The entity type '{entityType}' has a defining query configured. Compiled model can't be generated, because defining queries are not supported.</value>
@@ -142,16 +142,16 @@
     <value>The entity type '{entityType}' has a query filter configured. Compiled model can't be generated, because query filters are not supported.</value>
   </data>
   <data name="CompiledModelTypeMapping" xml:space="preserve">
-    <value>The property '{entityType}.{property}' has a custom type mapping configured. Compiled model can't be generated, because custom type mappings are not supported.</value>
+    <value>The property '{entityType}.{property}' has a custom type mapping configured. Configure it in '{customize}' in a partial '{className}' class instead.</value>
   </data>
   <data name="CompiledModelValueComparer" xml:space="preserve">
-    <value>The property '{entityType}.{property}' has a value comparer configured. Compiled model can't be generated, because value comparers are not supported.</value>
+    <value>The property '{entityType}.{property}' has a value comparer configured. Use '{method}' to configure the value comparer type.</value>
   </data>
   <data name="CompiledModelValueConverter" xml:space="preserve">
-    <value>The property '{entityType}.{property}' has a value converter configured. Compiled model can't be generated, because value converters are not supported.</value>
+    <value>The property '{entityType}.{property}' has a value converter configured. Use '{method}' to configure the value converter type.</value>
   </data>
   <data name="CompiledModelValueGenerator" xml:space="preserve">
-    <value>The property '{entityType}.{property}' has a value generator configured. Compiled model can't be generated, because value generators are not supported.</value>
+    <value>The property '{entityType}.{property}' has a value generator configured. Use '{method}' to configure the value generator factory type.</value>
   </data>
   <data name="ConflictingContextAndMigrationName" xml:space="preserve">
     <value>The name you have chosen for the migration, '{name}', is the same as the context class name. Please choose a different name for your migration. Might we suggest 'InitialCreate' for your first migration?</value>