Skip to content

Promote SQL Server bulk insert logic to relational ReaderModificationCommandBatch #29668

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
roji opened this issue Nov 24, 2022 · 0 comments
Open

Comments

@roji
Copy link
Member

roji commented Nov 24, 2022

SqlServerModificationCommandBatch has a bulk insert logic, where multiple insertions are coalesced into a single, efficient MERGE statement. We should promote the infrastructure for coalescing multiple modification commands into a single SQL statement to relational:

  • It would allow other providers to more easily implement bulk insert etc.
  • It's currently a bit tricky to implement the logic only in SqlServerModificationCommandBatch, without ReaderModificationCommandBatch knowing anything about it (e.g. this). Adding the proper hooks in ReaderModificationCommandBatch would simplify this.
  • We should make this support non-insertion as well (e.g. Implement bulk deletion with SaveChanges #27550).
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

2 participants