From 82c8f0ecfdcea3bd3a8a1633b439c74b311ecaec Mon Sep 17 00:00:00 2001 From: Shay Rojansky Date: Tue, 25 Aug 2020 12:04:11 +0300 Subject: [PATCH] Remove VB support from analyzer Fixes #22177 --- src/EFCore.Analyzers/EFCore.Analyzers.csproj | 1 - .../InternalUsageDiagnosticAnalyzer.cs | 10 ++-------- 2 files changed, 2 insertions(+), 9 deletions(-) diff --git a/src/EFCore.Analyzers/EFCore.Analyzers.csproj b/src/EFCore.Analyzers/EFCore.Analyzers.csproj index d1f0c17289d..86c654c8300 100644 --- a/src/EFCore.Analyzers/EFCore.Analyzers.csproj +++ b/src/EFCore.Analyzers/EFCore.Analyzers.csproj @@ -16,7 +16,6 @@ - diff --git a/src/EFCore.Analyzers/InternalUsageDiagnosticAnalyzer.cs b/src/EFCore.Analyzers/InternalUsageDiagnosticAnalyzer.cs index f4009c0fb55..5fe9f49e205 100644 --- a/src/EFCore.Analyzers/InternalUsageDiagnosticAnalyzer.cs +++ b/src/EFCore.Analyzers/InternalUsageDiagnosticAnalyzer.cs @@ -8,11 +8,10 @@ using Microsoft.CodeAnalysis.Diagnostics; using Microsoft.CodeAnalysis.Operations; using CSharpSyntax = Microsoft.CodeAnalysis.CSharp.Syntax; -using VBSyntax = Microsoft.CodeAnalysis.VisualBasic.Syntax; namespace Microsoft.EntityFrameworkCore { - [DiagnosticAnalyzer(LanguageNames.CSharp, LanguageNames.VisualBasic)] + [DiagnosticAnalyzer(LanguageNames.CSharp)] public class InternalUsageDiagnosticAnalyzer : DiagnosticAnalyzer { public const string Id = "EF1001"; @@ -300,12 +299,7 @@ CSharpSyntax.VariableDeclaratorSyntax declarator : (SyntaxNode)declarator, CSharpSyntax.TypeOfExpressionSyntax s => s.Type, - VBSyntax.InvocationExpressionSyntax s - when s.Expression is VBSyntax.MemberAccessExpressionSyntax memberAccessSyntax - => memberAccessSyntax.Name, - VBSyntax.MemberAccessExpressionSyntax s => s.Name, - VBSyntax.ObjectCreationExpressionSyntax s => s.Type, - VBSyntax.TypeOfExpressionSyntax s => s.Type, + // TODO: VB syntax narrowing (#22085) _ => syntax };