Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

withLangVersionPreview → withLangVersion in emitted IL tests when LowerIntegralRangesToFastLoops is out of preview #16739

Closed
brianrourkeboll opened this issue Feb 20, 2024 · 1 comment · Fixed by #17500
Closed

withLangVersionPreview → withLangVersion in emitted IL tests when LowerIntegralRangesToFastLoops is out of preview #16739

brianrourkeboll opened this issue Feb 20, 2024 · 1 comment · Fixed by #17500
Assignees
@KevinRansom
Labels
Engineering
Milestone
August-2024

Comments

@brianrourkeboll
Copy link
Contributor

brianrourkeboll commented Feb 20, 2024 •
edited
Loading

Certain tests (6056c45, 6ed642e) needed to be run with langversion preview in #16650 to update their IL baselines. This should changed to the specific language version in these tests once the LowerIntegralRangesToFastLoops feature is out of preview — likely F# 9. (Ctrl + Shift + F for this issue number in the source.)
@github-actions github-actions bot added this to the Backlog milestone Feb 20, 2024
@vzarytovskii
Copy link
Member

We don't want to remove them, but rather change them to using specific language (withLanguageVersion x.x), so we are sure we don't degrade any previous codegen/typechecking/etc.

@brianrourkeboll brianrourkeboll changed the title Remove withLangVersionPreview from emitted IL tests when LowerIntegralRangesToFastLoops is out of preview withLangVersionPreview → withLangVersion in emitted IL tests when LowerIntegralRangesToFastLoops is out of preview Mar 8, 2024
@KevinRansom KevinRansom self-assigned this Aug 6, 2024
@KevinRansom KevinRansom modified the milestones: Backlog, August-2024 Aug 6, 2024
@KevinRansom KevinRansom mentioned this issue Aug 7, 2024
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@KevinRansom KevinRansom

Labels
Engineering
Projects
F# Compiler and Tooling
Archived in project
Milestone
August-2024
Development

Successfully merging a pull request may close this issue.

Enable F# 9.0 KevinRansom/fsharp
3 participants
@vzarytovskii @KevinRansom @brianrourkeboll