-
Notifications
You must be signed in to change notification settings - Fork 795
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Fix or remove legacy VS tests #17330
Comments
Please don't remove the salsa tests. They have saved me numerous times (and likely not only me 😁). Even though I didn't like to debug them, they were the only failing ones and caught some actual regressions. |
They flaky, and start to fail all of the sudden. We will definitely remove them once we move out of process. |
Would be nice to port at least the completion tests then. |
Not gonna port, there will be just different completion tests for lsp |
CI is breaking for
WindowsCompressedMetadata
now.The text was updated successfully, but these errors were encountered: