Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix or remove legacy VS tests #17330

Open
psfinaki opened this issue Jun 20, 2024 · 4 comments
Open

Fix or remove legacy VS tests #17330

psfinaki opened this issue Jun 20, 2024 · 4 comments
Milestone

Comments

@psfinaki
Copy link
Member

CI is breaking for WindowsCompressedMetadata now.

@auduchinok
Copy link
Member

Please don't remove the salsa tests. They have saved me numerous times (and likely not only me 😁). Even though I didn't like to debug them, they were the only failing ones and caught some actual regressions.

@vzarytovskii
Copy link
Member

Please don't remove the salsa tests. They have saved me numerous times (and likely not only me 😁). Even though I didn't like to debug them, they were the only failing ones and caught some actual regressions.

They flaky, and start to fail all of the sudden. We will definitely remove them once we move out of process.

@auduchinok
Copy link
Member

They flaky, and start to fail all of the sudden. We will definitely remove them once we move out of process.

Would be nice to port at least the completion tests then.

@vzarytovskii
Copy link
Member

They flaky, and start to fail all of the sudden. We will definitely remove them once we move out of process.

Would be nice to port at least the completion tests then.

Not gonna port, there will be just different completion tests for lsp

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
Status: New
Development

No branches or pull requests

4 participants