[SpriteKit] Simplify SKVideoNode creation code. (#22719)

We don't need the creation code for older OS versions, because we don't
support those older OS versions anymore, which means we can just simplify this
all to generated bindings.

Author: rolfbjarne

src/SpriteKit/SKVideoNode.cs

@@ -1640,7 +1640,6 @@ SPRITEKIT_SOURCES = \
 	SpriteKit/SKKeyframeSequence.cs \
 	SpriteKit/SKNode.cs \
 	SpriteKit/SKShapeNode.cs \
-	SpriteKit/SKVideoNode.cs \
 	SpriteKit/SKWarpGeometryGrid.cs \
 
 # StoreKit

src/frameworks.sources

@@ -1499,33 +1499,31 @@ partial interface SKVideoNode {
 		[Static, Export ("videoNodeWithAVPlayer:")]
 		SKVideoNode FromPlayer (AVPlayer player);
 
-		[Static, Export ("videoNodeWithVideoFileNamed:"), Internal]
-		SKVideoNode VideoNodeWithVideoFileNamed (string videoFile);
+		/// <summary>Create a video node from the named video file.</summary>
+		/// <param name="videoFile">The video file to create the <see cref="SKVideoNode" /> from.</param>
+		[Static, Export ("videoNodeWithFileNamed:")]
+		SKVideoNode FromFile (string videoFile);
 
-		[Static, Export ("videoNodeWithFileNamed:"), Internal]
-		SKVideoNode VideoNodeWithFileNamed (string videoFile);
-
-		[Static, Export ("videoNodeWithVideoURL:"), Internal]
-		SKVideoNode VideoNodeWithVideoURL (NSUrl videoURL);
-
-		[Static, Export ("videoNodeWithURL:"), Internal]
-		SKVideoNode VideoNodeWithURL (NSUrl videoURL);
+		/// <summary>Creates a video node from the file at the specified URL.</summary>
+		/// <param name="videoUrl">The video url to create the <see cref="SKVideoNode" /> from.</param>
+		[Static, Export ("videoNodeWithURL:")]
+		SKVideoNode FromUrl (NSUrl videoUrl);
 
 		[DesignatedInitializer]
 		[Export ("initWithAVPlayer:")]
 		NativeHandle Constructor (AVPlayer player);
 
-		[Export ("initWithVideoFileNamed:"), Internal]
-		IntPtr InitWithVideoFileNamed (string videoFile);
-
-		[Export ("initWithFileNamed:"), Internal]
-		IntPtr InitWithFileNamed (string videoFile);
-
-		[Export ("initWithVideoURL:"), Internal]
-		IntPtr InitWithVideoURL (NSUrl url);
+		/// <summary>Create a video node from the named video file.</summary>
+		/// <param name="videoFile">The video file to create the <see cref="SKVideoNode" /> from.</param>
+		[Export ("initWithFileNamed:")]
+		[DesignatedInitializer]
+		NativeHandle Constructor (string videoFile);
 
-		[Export ("initWithURL:"), Internal]
-		IntPtr InitWithURL (NSUrl url);
+		/// <summary>Creates a video node from the file at the specified URL.</summary>
+		/// <param name="url">The video url to create the <see cref="SKVideoNode" /> from.</param>
+		[Export ("initWithURL:")]
+		[DesignatedInitializer]
+		NativeHandle Constructor (NSUrl url);
 
 		[Export ("play")]
 		void Play ();

src/spritekit.cs

@@ -46,8 +46,6 @@ public partial class ConstructorTest {
 			"ModelIO.MDLMesh::.ctor(System.Numerics.Vector3,CoreGraphics.NVector3i,System.Boolean,ModelIO.MDLGeometryType,ModelIO.IMDLMeshBufferAllocator)",
 			"ModelIO.MDLMesh::.ctor(System.Numerics.Vector3,System.Boolean,ModelIO.MDLGeometryType,ModelIO.IMDLMeshBufferAllocator)",
 			"ModelIO.MDLNoiseTexture::.ctor(System.Single,System.String,CoreGraphics.NVector2i,ModelIO.MDLTextureChannelEncoding,ModelIO.MDLNoiseTextureType)",
-			"SpriteKit.SKVideoNode::.ctor(Foundation.NSUrl)",
-			"SpriteKit.SKVideoNode::.ctor(System.String)",
 			"SpriteKit.SKWarpGeometryGrid::.ctor(System.IntPtr,System.IntPtr,System.Numerics.Vector2[],System.Numerics.Vector2[])",
 			"UIKit.UIControlEventProxy::.ctor(UIKit.UIControl,System.EventHandler)",
 			"UIKit.UIImageStatusDispatcher::.ctor(UIKit.UIImage/SaveStatus)",

tests/cecil-tests/ConstructorTest.KnownFailures.cs

@@ -23,8 +23,6 @@ public partial class SetHandleTest {
 			"ScreenCaptureKit.SCContentFilter::.ctor(ScreenCaptureKit.SCDisplay,ScreenCaptureKit.SCRunningApplication[],ScreenCaptureKit.SCWindow[],ScreenCaptureKit.SCContentFilterOption)",
 			"ScreenCaptureKit.SCContentFilter::.ctor(ScreenCaptureKit.SCDisplay,ScreenCaptureKit.SCWindow[],ScreenCaptureKit.SCContentFilterOption)",
 			"Security.SecTrust2::.ctor(Security.SecTrust)",
-			"SpriteKit.SKVideoNode::.ctor(Foundation.NSUrl)",
-			"SpriteKit.SKVideoNode::.ctor(System.String)",
 		};
 	}
 }