Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Reconsideration of Source Embedding #34

Open
aetos382 opened this issue Sep 28, 2023 · 1 comment
Open

Reconsideration of Source Embedding #34

aetos382 opened this issue Sep 28, 2023 · 1 comment

Comments

@aetos382
Copy link
Contributor

Using this package, the following options are set.

<DebugType>embedded</DebugType>.
<EmbedUntrackedSources>true</EmbedUntrackedSources>

With this setting, all source code generated by Source Generators will be embedded in the EXE/DLL via PDB.
I think that these source embedding options need to be reconsidered.

@MattKotsenas
Copy link
Member

Can you tell me more about the impact / downside?

Are you in a scenario where your source generator is generating a large amount of code and bloating PDB? Is the source generator generating non-deterministic code?

Depending on the scenario, we may want to change our guidance / defaults, however without knowing more about the scenario I'm hesitant to suggest changes here.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants