Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove old options related to solution crawler #77625

Open
wants to merge 1 commit into
base: release/dev18.0
Choose a base branch
from

Conversation

CyrusNajmabadi
Copy link
Member

No description provided.

@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner March 15, 2025 05:50
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Mar 15, 2025
@@ -17,15 +16,11 @@ namespace Microsoft.VisualStudio.LanguageServices.Options;
internal sealed class PackageSettingsPersister : IOptionPersister
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if we need this type at all now.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It sure doesn't look like it to me

@ToddGrun
Copy link
Contributor

Would it make sense to do this against the post 17.14 branch as that's where the other package initialization cleanup is going?

@CyrusNajmabadi
Copy link
Member Author

Yes. I'll move it there.

@CyrusNajmabadi CyrusNajmabadi changed the base branch from main to release/dev18.0 March 15, 2025 20:20
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead VSCode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants