Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Mono] Re-enable hardware intrinsics tests when LLVM JIT is enabled for llvmaot lanes #75767

Closed
Tracked by #75757
fanyang-mono opened this issue Sep 16, 2022 · 3 comments
Assignees
Labels
area-Codegen-LLVM-mono disabled-test The test is disabled in source code against the issue
Milestone

Comments

@fanyang-mono
Copy link
Member

fanyang-mono commented Sep 16, 2022

The following tests failed on mono llvmaot Pri0 Runtime Tests Run Linux x64 release after #75055 disabled LLVM for the JIT fallback. Detailed failure log could be found from build

They passed when I tested locally by enabling LLVM JIT. Tests being disabed by #75768 need to be re-enabled.

To enable LLVM JIT, the change to src/tests/Common/testenvironment.proj in #75055 needs to be reverted.

@jandupej
Copy link
Member

LLVM JIT is no longer supported on Mono side. Closing.

@fanyang-mono
Copy link
Member Author

@jandupej It is a good idea to close this issue according to the reason you mentioned above. However, the associated tests are still disabled in issues.target file with a link to this issue. It would be helpful to link those tests with a new issue. It looks like that they are all X86 intrinsics related.

For example:
https://github.com/dotnet/runtime/blob/main/src/tests/issues.targets#L2282-L2365

@jandupej
Copy link
Member

@jandupej It is a good idea to close this issue according to the reason you mentioned above. However, the associated tests are still disabled in issues.target file with a link to this issue. It would be helpful to link those tests with a new issue. It looks like that they are all X86 intrinsics related.

For example: https://github.com/dotnet/runtime/blob/main/src/tests/issues.targets#L2282-L2365

Good point. They are now tracked in #91392.

@ghost ghost locked as resolved and limited conversation to collaborators Sep 30, 2023
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
area-Codegen-LLVM-mono disabled-test The test is disabled in source code against the issue
Projects
None yet
Development

No branches or pull requests

3 participants