Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Run low level EventPipe and container type native tests on CI. #82396

Closed
lateralusX opened this issue Feb 20, 2023 · 1 comment
Closed

Run low level EventPipe and container type native tests on CI. #82396

lateralusX opened this issue Feb 20, 2023 · 1 comment
Labels
area-Tracing-mono test-enhancement Improvements of test source code
Milestone

Comments

@lateralusX
Copy link
Member

#78852 adds a set of new native container types, primarily used by EventPipe. EventPipe includes a set of low level native tests currently executed using eglibs test runner. The new native container types piggy backs on this and adds its test suites into the same native test runner. Currently these tests are only run local and only on Mono.

This issue is filed so we can decide how we should write low level native tests like this and how they can be run on CI for all runtimes using tested libraries (currently EventPipe and Containers). Current tests uses eglibs tests runner, so if we don't need more support than what it implements, we should move that test runner into src/native and use it for low level native tests like this. We also need to decide how to run this on CI, since tests produce a native binary that can be run and that reports success/failure we should probably add support that just runs these test binaries and make sure the output gets included on CI test reports.

@ghost ghost added the untriaged New issue has not been triaged by the area owner label Feb 20, 2023
@lateralusX lateralusX added test-enhancement Improvements of test source code and removed untriaged New issue has not been triaged by the area owner labels Feb 20, 2023
@lateralusX lateralusX added this to the 9.0.0 milestone Jul 18, 2023
@tommcdon
Copy link
Member

tommcdon commented Apr 9, 2024

After reviewing this issue, we have decided that we are unable to prioritize it. Closing the issue for now until we discover that adding the low-level unit tests would be useful for catching regressions.

@tommcdon tommcdon closed this as completed Apr 9, 2024
@github-actions github-actions bot locked and limited conversation to collaborators May 10, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
area-Tracing-mono test-enhancement Improvements of test source code
Projects
None yet
Development

No branches or pull requests

3 participants