Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[wasm] v8 crashing at the end with "Reached heap limit" - for AOT builds #88497

Closed
radical opened this issue Jul 6, 2023 · 9 comments
Closed
Assignees
Labels
arch-wasm WebAssembly architecture area-VM-meta-mono Known Build Error Use this to report build issues in the .NET Helix tab
Milestone

Comments

@radical
Copy link
Member

radical commented Jul 6, 2023

Rolling build, and log:

[21:57:26] info: Using random seed for test cases: 1670696355
[21:57:26] info: Using random seed for collections: 1670696355
[21:57:26] info: Starting:    System.Collections.Immutable.Tests.dll

...

[21:58:11] info: [STRT] System.Collections.Frozen.Tests.FrozenSet_Generic_Tests_string_NonDefault.IEnumerable_Generic_Enumerator_MoveNextFalseAfterEndOfCollection
[21:58:11] info: Finished:    System.Collections.Immutable.Tests.dll
[21:58:11] info: 
[21:58:11] info: === TEST EXECUTION SUMMARY ===
[21:58:11] info: Total: 20385, Errors: 0, Failed: 0, Skipped: 50, Time: 44.875336s
[21:58:11] info: 
[21:58:16] info: 
[21:58:16] info: <--- Last few GCs --->
[21:58:16] info: 
[21:58:16] info: [417:0x5634905f12f0]    51715 ms: Mark-Compact 2023.1 (2064.6) -> 2023.1 (2064.6) MB, 763.97 / 0.00 ms  (average mu = 0.356, current mu = 0.089) allocation failure; scavenge might not succeed
[21:58:16] info: [417:0x5634905f12f0]    52663 ms: Mark-Compact 2030.8 (2064.6) -> 2030.8 (2080.3) MB, 942.13 / 0.00 ms  (average mu = 0.189, current mu = 0.007) allocation failure; scavenge might not succeed
[21:58:16] info: 
[21:58:16] info: 
[21:58:16] info: <--- JS stacktrace --->
[21:58:16] info: 
[21:58:16] info: 
[21:58:16] info: #
[21:58:16] info: # Fatal JavaScript out of memory: Reached heap limit
[21:58:16] info: #
[21:58:16] info: 
[21:58:43] info: /home/helixbot/.jsvu/bin/v8: line 2:   417 Trace/breakpoint trap   (core dumped) "/home/helixbot/.jsvu/engines/v8/v8" --snapshot_blob="/home/helixbot/.jsvu/engines/v8/snapshot_blob.bin" "$@"
[21:58:43] info: Process v8 exited with 133

Another instance - build, and log.

This was hit twice in three rolling build runs. Changes from the last passing build before the first hit: 76a8f4f...18321c6 .

cc @vargaz

Known Issue Error Message

Fill the error message using step by step known issues guidance.

{
  "ErrorPattern": "Fatal JavaScript out of memory: Reached heap limit",
  "BuildRetry": false,
  "ExcludeConsoleLog": false
}

Known issue validation

Build: 🔎 https://dev.azure.com/dnceng-public/public/_build/results?buildId=331212
Error message validated: Fatal JavaScript out of memory: Reached heap limit
Result validation: ✅ Known issue matched with the provided build.
Validation performed at: 7/6/2023 10:39:28 PM UTC

Report

Build Definition Test Pull Request
334566 dotnet/runtime normal-System.Text.RegularExpressions.Tests.WorkItemExecution #88279
331212 dotnet/runtime normal-System.Collections.Immutable.Tests.WorkItemExecution
329962 dotnet/runtime normal-System.Collections.Immutable.Tests.WorkItemExecution

Summary

24-Hour Hit Count 7-Day Hit Count 1-Month Count
0 0 3
@radical radical added arch-wasm WebAssembly architecture blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' area-VM-meta-mono labels Jul 6, 2023
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Jul 6, 2023
@ghost
Copy link

ghost commented Jul 6, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Rolling build, and log:

[21:57:26] info: Using random seed for test cases: 1670696355
[21:57:26] info: Using random seed for collections: 1670696355
[21:57:26] info: Starting:    System.Collections.Immutable.Tests.dll

...

[21:58:11] info: [STRT] System.Collections.Frozen.Tests.FrozenSet_Generic_Tests_string_NonDefault.IEnumerable_Generic_Enumerator_MoveNextFalseAfterEndOfCollection
[21:58:11] info: Finished:    System.Collections.Immutable.Tests.dll
[21:58:11] info: 
[21:58:11] info: === TEST EXECUTION SUMMARY ===
[21:58:11] info: Total: 20385, Errors: 0, Failed: 0, Skipped: 50, Time: 44.875336s
[21:58:11] info: 
[21:58:16] info: 
[21:58:16] info: <--- Last few GCs --->
[21:58:16] info: 
[21:58:16] info: [417:0x5634905f12f0]    51715 ms: Mark-Compact 2023.1 (2064.6) -> 2023.1 (2064.6) MB, 763.97 / 0.00 ms  (average mu = 0.356, current mu = 0.089) allocation failure; scavenge might not succeed
[21:58:16] info: [417:0x5634905f12f0]    52663 ms: Mark-Compact 2030.8 (2064.6) -> 2030.8 (2080.3) MB, 942.13 / 0.00 ms  (average mu = 0.189, current mu = 0.007) allocation failure; scavenge might not succeed
[21:58:16] info: 
[21:58:16] info: 
[21:58:16] info: <--- JS stacktrace --->
[21:58:16] info: 
[21:58:16] info: 
[21:58:16] info: #
[21:58:16] info: # Fatal JavaScript out of memory: Reached heap limit
[21:58:16] info: #
[21:58:16] info: 
[21:58:43] info: /home/helixbot/.jsvu/bin/v8: line 2:   417 Trace/breakpoint trap   (core dumped) "/home/helixbot/.jsvu/engines/v8/v8" --snapshot_blob="/home/helixbot/.jsvu/engines/v8/snapshot_blob.bin" "$@"
[21:58:43] info: Process v8 exited with 133

Another instance - build, and log.

This was hit twice in three rolling build runs. Changes from the last passing build before the first hit: 76a8f4f...18321c6 .

cc @vargaz

Author: radical
Assignees: -
Labels:

arch-wasm, blocking-clean-ci, area-VM-meta-mono

Milestone: -

@radical radical added this to the 8.0.0 milestone Jul 6, 2023
@ghost ghost removed the untriaged New issue has not been triaged by the area owner label Jul 6, 2023
@vargaz
Copy link
Contributor

vargaz commented Jul 7, 2023

Can't reproduce with the same seed. Tried setting --max-heap-size= as well, it crashes with 512, but works with 612, so the app uses about 600mb of heap.

@radical radical added the Known Build Error Use this to report build issues in the .NET Helix tab label Jul 10, 2023
@lewing
Copy link
Member

lewing commented Jul 21, 2023

Did we disable this test or did it stop happening?

@vargaz
Copy link
Contributor

vargaz commented Jul 22, 2023

This might be the same as:
#87078

@radical radical removed the blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' label Jul 22, 2023
@radical
Copy link
Member Author

radical commented Jul 22, 2023

I think these run close to the limit, and sometimes end up exceeding the heap limit, so we don't see them all the time.

@radical radical changed the title [wasm] System.Collections.Immutable.Tests - v8 crashing at the end with "Reached heap limit" - for AOT builds [wasm] v8 crashing at the end with "Reached heap limit" - for AOT builds Jul 22, 2023
@lewing
Copy link
Member

lewing commented Jul 25, 2023

I think these run close to the limit, and sometimes end up exceeding the heap limit, so we don't see them all the time.

right but @kg fixed an issue that may have resolved this

@vargaz
Copy link
Contributor

vargaz commented Jul 25, 2023

Does this still happen after that fix ?

@radical
Copy link
Member Author

radical commented Jul 25, 2023

Does this still happen after that fix ?

I have not seen this recently.

@radical
Copy link
Member Author

radical commented Jul 25, 2023

Closing this. It can be re-opened if it is hit again.

@radical radical closed this as completed Jul 25, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Aug 25, 2023
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
arch-wasm WebAssembly architecture area-VM-meta-mono Known Build Error Use this to report build issues in the .NET Helix tab
Projects
None yet
Development

No branches or pull requests

4 participants