Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Validate ILLink support for ref structs within generics #98519

Closed
Tracked by #65112
sbomer opened this issue Feb 15, 2024 · 2 comments · Fixed by #103452
Closed
Tracked by #65112

Validate ILLink support for ref structs within generics #98519

sbomer opened this issue Feb 15, 2024 · 2 comments · Fixed by #103452
Assignees
@sbomer
Labels
area-Tools-ILLink .NET linker development as well as trimming analyzers in-pr There is an active PR which will close this issue when it is merged
Milestone
9.0.0

Comments

@sbomer
Copy link
Member

sbomer commented Feb 15, 2024

We need to ensure that Cecil and ILLink correctly preserve the metadata for ref structs used as generic arguments. As mentioned in #65112 (comment), we can use IL tests for this in illink. Part of #65112
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Feb 15, 2024
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Feb 15, 2024
@sbomer sbomer mentioned this issue Feb 15, 2024
Open
13 tasks
@sbomer sbomer added this to AppModel Feb 15, 2024
@sbomer sbomer added the area-Tools-ILLink .NET linker development as well as trimming analyzers label Feb 15, 2024
@ghost
Copy link

ghost commented Feb 15, 2024

Tagging subscribers to this area: @agocke, @sbomer, @vitek-karas
See info in area-owners.md if you want to be subscribed.

Issue Details

We need to ensure that Cecil and ILLink correctly preserve the metadata for ref structs used as generic arguments. As mentioned in #65112 (comment), we can use IL tests for this in illink. Part of #65112

Author: sbomer
Assignees: -
Labels:

untriaged, area-Tools-ILLink, needs-area-label
Milestone: -

@sbomer sbomer added this to the 9.0.0 milestone Feb 15, 2024
@ghost ghost removed the untriaged New issue has not been triaged by the area owner label Feb 15, 2024
@sbomer sbomer removed the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Feb 15, 2024
@sbomer sbomer self-assigned this Apr 25, 2024
@sbomer sbomer moved this to High Priority in AppModel Apr 25, 2024
@vitek-karas
Copy link
Member

See #65112 (comment) for Cecil.

@sbomer sbomer mentioned this issue Jun 5, 2024
Merged
@sbomer sbomer mentioned this issue Jun 13, 2024
Merged
@dotnet-policy-service dotnet-policy-service bot added the in-pr There is an active PR which will close this issue when it is merged label Jun 13, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jul 18, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Assignees

@sbomer sbomer

Labels
area-Tools-ILLink .NET linker development as well as trimming analyzers in-pr There is an active PR which will close this issue when it is merged
Projects
AppModel
Archived in project
Milestone
9.0.0
Development

Successfully merging a pull request may close this issue.

Validate generic constraints in ILLink tests sbomer/runtime
2 participants
@sbomer @vitek-karas