Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Microsoft.NET.Build.Containers version '8.0.202' warning is incorrect on 8.0.1xx SDK #39931

Closed
richlander opened this issue Apr 2, 2024 · 2 comments
Labels
Area-Containers Related to dotnet SDK containers functionality untriaged Request triage from a team member

Comments

@richlander
Copy link
Member

I'm using .NET 8 from the Ubuntu archive on Ubuntu 24.04.

$ dotnet --version
8.0.102
$ dotnet add package Microsoft.NET.Build.Containers
$ dotnet publish -t:PublishContainer -p:EnableSdkContainerSupport=true
MSBuild version 17.8.5+b5265ef37 for .NET
  Determining projects to restore...
  All projects are up-to-date for restore.
  dotnetapp -> /home/rich/git/dotnet-docker/samples/dotnetapp/bin/Release/net8.0/dotnetapp.dll
/home/rich/.nuget/packages/microsoft.net.build.containers/8.0.202/build/Microsoft.NET.Build.Containers.targets(194,5): warning : Microsoft.NET.Build.Containers NuGet package is explicitly referenced. Consider removing the package reference to Microsoft.NET.Build.Containers as it is now part of .NET SDK. [/home/rich/git/dotnet-docker/samples/dotnetapp/dotnetapp.csproj]
  dotnetapp -> /home/rich/git/dotnet-docker/samples/dotnetapp/bin/Release/net8.0/publish/
  Building image 'dotnetapp' with tags 'latest' on top of base image 'mcr.microsoft.com/dotnet/runtime:8.0'.
  Pushed image 'dotnetapp:latest' to local registry via 'docker'.

That's not the best, right? So, either the package should only emit that warning with 8.0.200+ or we should have guidance to use an 8.0.1xx package for an 8.0.1xx SDK (AKA "matching").

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Linux untriaged Request triage from a team member labels Apr 2, 2024
@baronfel
Copy link
Member

baronfel commented Apr 2, 2024

We made this message back in 7.0.300 when we first added native-SDK support for WebApps and it hasn't been updated to account for the versioning relationship for the newly supported project types. We should take another pass at it, especially because 8.0 is LTS and 8.0.100 will be the most easily-accessible version for our Linux users.

@baronfel
Copy link
Member

baronfel commented May 2, 2024

Going to close this as we've updated the message and initiated backports to the relevant branches.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Area-Containers Related to dotnet SDK containers functionality untriaged Request triage from a team member
Projects
None yet
Development

No branches or pull requests

2 participants