Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Build break on Registry types #199

Closed
AArnott opened this issue Mar 14, 2020 · 2 comments · Fixed by #200
Closed

Build break on Registry types #199

AArnott opened this issue Mar 14, 2020 · 2 comments · Fixed by #200

Comments

@AArnott
Copy link
Contributor

AArnott commented Mar 14, 2020

I don't know how this is building in Azure Pipelines. The SignService is targeting netcoreapp3.1 but not referencing the Microsoft.Win32.Registry package. So local builds fail with this:

Utils\mansign2.cs(877,27): error CS0103: The name 'Registry' does not exist in the current context [D:\git\SignService\src\SignService\SignService.csproj] Utils\mansign2.cs(881,33): error CS0103: The name 'RegistryValueKind' does not exist in the current context [D:\git\SignService\src\SignService\SignService.csproj]
Utils\mansign2.cs(881,68): error CS0103: The name 'RegistryValueKind' does not exist in the current context [D:\git\SignService\src\SignService\SignService.csproj]

Is this really a configuration fail on my part somehow?

I'd like to send a PR that fixes the build break on my machine. I'd just feel better knowing how it works for anybody else.

@clairernovotny
Copy link
Contributor

clairernovotny commented Mar 14, 2020

This is because of a bug in the 3.1.102 SDK. I just haven't put in the workaround for it; send you email offline.

@AArnott
Copy link
Contributor Author

AArnott commented Mar 14, 2020

I stand corrected. It does fail in Azure Pipelines before my fix.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants