Skip to content

Container image with scancode preinstalled #3816

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
mthalman opened this issue Jan 2, 2024 · 4 comments · Fixed by dotnet/dotnet#253
Closed

Container image with scancode preinstalled #3816

mthalman opened this issue Jan 2, 2024 · 4 comments · Fixed by dotnet/dotnet#253
Assignees
Labels
area-testing Improvements in CI and testing

Comments

@mthalman
Copy link
Member

mthalman commented Jan 2, 2024

The license scan smoke test requires that scancode toolkit be installed. This is currently done within the pipeline. A better configuration would be to have a container image defined which already contains scancode and have the build agent use that image. This can be done via the https://github.com/dotnet/dotnet-buildtools-prereqs-docker repo.

An open question is whether this should be installed into the base image used by source build to build the VMR or whether a separate image should be defined.

@MichaelSimons MichaelSimons added area-testing Improvements in CI and testing and removed area-ci-testing labels Jan 3, 2024
@mthalman mthalman removed the untriaged label Jan 4, 2024
@mthalman mthalman moved this from Backlog to 9.0 in .NET Source Build Jan 4, 2024
@MichaelSimons MichaelSimons moved this from 9.0 to 10.0 in .NET Source Build Jul 2, 2024
@MichaelSimons MichaelSimons moved this from 10.0 to 10 Candidate in .NET Source Build Feb 6, 2025
@MichaelSimons MichaelSimons moved this from 10 Candidate to Backlog in .NET Source Build Mar 27, 2025
@Winniexu01 Winniexu01 self-assigned this Apr 16, 2025
@Winniexu01 Winniexu01 moved this from Backlog to In Progress in .NET Source Build Apr 16, 2025
@mthalman
Copy link
Member Author

The container image should be used as a container job within the Azure DevOps pipeline. So the other requirements that it would need are to have .NET SDK installed since the job needs to build and run the license scan tests. Since it's going to have the .NET SDK installed, we don't want this same container image to be used for source build; we'd want a dedicated image specifically for scancode.

@Winniexu01
Copy link
Member

Hi @mthalman , regarding the .NET SDK version, it's actually defined in this global.json. My current approach is to install a fixed version (e.g., main - 10.0.100-preview.4.25216.3), and update the corresponding container image if major version update. I'd like to check if you have any other suggestions or recommendations for handling SDK version.

@mthalman
Copy link
Member Author

It should just make use of the existing .NET SDK container image (mcr.microsoft.com/dotnet/sdk:10.0-preview) and install scancode on top of that.

@MichaelSimons
Copy link
Member

It should just make use of the existing .NET SDK container image (mcr.microsoft.com/dotnet/sdk:10.0-preview) and install scancode on top of that.

Was there any consideration to use Azure Linux vs Ubuntu? I would think Azure Linux would have been a better choice for use given it's usage.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
area-testing Improvements in CI and testing
Projects
Status: Done
3 participants