Offline builds fail trying to access online feeds

[MichaelSimons]

  /vmr/artifacts/source-built-sdks/Microsoft.DotNet.Arcade.Sdk/tools/Tools.proj : error NU1301: Unable to load the service index for source https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-public/nuget/v3/index.json.

Failing build (internal microsoft link) - https://dev.azure.com/dnceng/internal/_build/results?buildId=2373582&view=logs&j=a361eaf5-91c0-5b8d-1f36-c97d0865c360&t=8198a24c-af12-5a92-d480-67a88a3b425d

[mthalman]

I think this is what was fixed by dotnet/installer#18565. The full VMR build hasn't run since that came in. The lite pipeline is passing.

[ellahathaway]

For source build monitoring - the latest run of source-build-sdk-diff-tests is failing in all legs due to this issue; latest run cannot find any associated artifacts from the full build.

[MichaelSimons]

I think this is what was fixed by dotnet/installer#18565. The full VMR build hasn't run since that came in. The lite pipeline is passing.

I triggered a new run this morning after those changes. - I updated the linked build.

[MichaelSimons]

@jkoritzinsky, can you take a look?

[jkoritzinsky]

Looks like it's failing to find the Microsoft.Dotnet.SourceBuild.Tasks library locally. I'll try to figure out how this was working beforehand.

[jkoritzinsky]

@MichaelSimons looks like the RestoreConfigFile isn't being passed down. The fix for this is in dotnet/runtime#97778, which is newer than the dotnet/runtime currently in the VMR (https://github.com/dotnet/runtime/commits/d40c654c274fe4f4afe66328f0599130f3eb2ea6).

Once this change flows through (dotnet/installer#18457), then this should be fixed.

[MichaelSimons]

Interesting, I thought we were already carrying the fix for dotnet/runtime#97778 as a patch - https://github.com/dotnet/installer/blob/main/src/SourceBuild/patches/runtime/0001-Enable-use-of-RestoreConfigFile-property-in-source-b.patch

When I look at the tip of the VMR, This doesn't appear to be applied.

[MichaelSimons]

That patch somehow didn't get re-applied in dotnet/dotnet@02e3703 and was dropped. @premun, Can you explain what happened here?

[MichaelSimons]

This issue was resolved with the latest sdk->installer dependency flow which removed all runtime patches.

The underlying issue with the sync not applying patches is tracked with dotnet/arcade-services#3286