Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove workaround for facade reference #3106

Open
weltkante opened this issue Apr 21, 2020 · 2 comments
Open

Remove workaround for facade reference #3106

weltkante opened this issue Apr 21, 2020 · 2 comments
Milestone

Comments

@weltkante
Copy link
Contributor

weltkante commented Apr 21, 2020

.NET Core Version:
.NET Core 5.0 (master branch)

Have you experienced this same bug with .NET Framework?:
No (not applicable)

Problem description:
For resolution of issue #2413 (PR #3098) a workaround for dotnet/sdk#3254 is required, this issue serves for tracking removal of the workaround once the SDK bug is resolved.

The bug affects all ProjectReference in that the generated deps.json doesn't contain the referenced version number, but currently only for System.Drawing it is causing problems for assembly resolution, so the workaround is only present there. Might be added to other references as required.

Expected behavior:
No workaround required for ProjectReference to a facade assembly

Minimal repro:
Reference a facade assembly and observe that the deps.json produced as build output does not include the version of the assembly you referenced:

        "runtime": {
          "System.Drawing.dll": {}
        }
@merriemcgaw merriemcgaw added this to the Future milestone Apr 23, 2020
@elachlan
Copy link
Contributor

@weltkante is this work around still necessary, now we have System.Drawing as a project in the solution?

@weltkante
Copy link
Contributor Author

I don't see System.Drawing as project in the solution on the current main branch, am I missing something? The facade project always has been there.

Tried removing the workaround from PR #3098 anyways to see if something else changed but the issue is still present and the unit test fails without the workaround.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants