[Cleanup] Use named arguments in System.Xaml #10061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
requested review from
dipeshmsft,
singhashish-wpf and
Kuldeep-MS
dotnet-policy-service
bot
added
PR
ThomasGoulet73
changed the title
himgoyalmicro
previously approved these changes
Dec 18, 2024
|
LGTM. We have included it in test pass, and I will have the result soon. |
Contributes to dotnet#10018
ThomasGoulet73
force-pushed
the
cleanup-use-named-arguments-in-System.Xaml
branch
from
ebae0b1 to
f9066f0
Compare
|
Done. |
harshit7962
added
Status:Completed
and removed
Status:InProgress
Status:Proposed
labels
himgoyalmicro
approved these changes
Dec 30, 2024
|
Thank you @ThomasGoulet73 for your contribution 😄 |
|
Thanks |
ThomasGoulet73
deleted the
cleanup-use-named-arguments-in-System.Xaml
branch
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #10018
Description
I replaced comments specifying an argument name with named arguments, which were introduced in C# 7. This improves readability and maintainability.
Note: The compiled IL is identical.
Customer Impact
None.
Regression
No.
Testing
Local build + validated IL.
Risk
Low to none.
Microsoft Reviewers: Open in CodeFlow