Add more System.Xaml tests #8203

hughbe · 2023-09-12T09:28:34Z

Had these lying around from 5 years ago. Can now send in after #138

Microsoft Reviewers: Open in CodeFlow

hughbe · 2023-09-12T13:30:49Z

There's a faulty debug assertion in XamlNode that's crashing the tests:

Process terminated. Assertion failed.
XamlNode ctor, StartMember data is not a XamlMember
   at System.Xaml.XamlNode..ctor(XamlNodeType nodeType, Object data) in /_/src/Microsoft.DotNet.Wpf/src/System.Xaml/System/Xaml/InfosetObjects/XamlNodes.cs:line 70
   at System.Xaml.XamlNodeQueue.Add(XamlNodeType nodeType, Object data) in /_/src/Microsoft.DotNet.Wpf/src/System.Xaml/System/Xaml/XamlNodeQueue.cs:line 65
   at System.Xaml.WriterDelegate.WriteStartMember(XamlMember member) in /_/src/Microsoft.DotNet.Wpf/src/System.Xaml/System/Xaml/WriterDelegate.cs:line 47
   at System.Xaml.Tests.XamlNodeQueueTests.Writer_WriteStartMember_Success(XamlMember member) in /_/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Xaml/XamlNodeQueueTests.cs:line 201
   at InvokeStub_XamlNodeQueueTests.Writer_WriteStartMember_Success(Object, Span`1)
   at System.Reflection.MethodBaseInvoker.InvokeWithOneArg(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
   at System.Reflection.MethodBase.Invoke(Object obj, Object[] parameters)
   at Xunit.Sdk.TestInvoker`1.CallTestMethod(Object testClassInstance) in C:\Dev\xunit\xunit\src\xunit.execution\Sdk\Frameworks\Runners\TestInvoker.cs:line 150
   at Xunit.Sdk.TestInvoker`1.<>c__DisplayClass48_1.<<InvokeTestMethodAsync>b__1>d.MoveNext() in C:\Dev\xunit\xunit\src\xunit.execution\Sdk\Frameworks\Runners\TestInvoker.cs:line 257
   at System.Runtime.CompilerServices.AsyncMethodBuilderCore.Start[TStateMachine](TStateMachine& stateMachine)
   at Xunit.Sdk.TestInvoker`1.<>c__DisplayClass48_1.<InvokeTestMethodAsync>b__1()
   at Xunit.Sdk.ExecutionTimer.AggregateAsync(Func`1 asyncAction) in C:\Dev\xunit\xunit\src\xunit.execution\Sdk\Frameworks\ExecutionTimer.cs:line 48
   at System.Runtime.CompilerServices.AsyncMethodBuilderCore.Start[TStateMachine](TStateMachine& stateMachine)
   at Xunit.Sdk.ExecutionTimer.AggregateAsync(Func`1 asyncAction)
   at Xunit.Sdk.TestInvoker`1.<>c__DisplayClass48_1.<InvokeTestMethodAsync>b__0() in C:\Dev\xunit\xunit\src\xunit.execution\Sdk\Frameworks\Runners\TestInvoker.cs:line 242
   at Xunit.Sdk.ExceptionAggregator.RunAsync(Func`1 code) in C:\Dev\xunit\xunit\src\xunit.core\Sdk\ExceptionAggregator.cs:line 90
   at System.Runtime.CompilerServices.AsyncMethodBuilderCore.Start[TStateMachine](TStateMachine& stateMachine)
   at Xunit.Sdk.ExceptionAggregator.RunAsync(Func`1 code)
   at Xunit.Sdk.TestInvoker`1.InvokeTestMethodAsync(Object testClassInstance) in C:\Dev\xunit\xunit\src\xunit.execution\Sdk\Frameworks\Runners\TestInvoker.cs:line 241
   at System.Runtime.CompilerServices.AsyncMethodBuilderCore.Start[TStateMachine](TStateMachine& stateMachine)
   at Xunit.Sdk.TestInvoker`1.InvokeTestMethodAsync(Object testClassInstance)
   at Xunit.Sdk.XunitTestInvoker.InvokeTestMethodAsync(Object testClassInstance) in C:\Dev\xunit\xunit\src\xunit.execution\Sdk\Frameworks\Runners\XunitTestInvoker.cs:line 112
   at Xunit.Sdk.TestInvoker`1.<RunAsync>b__47_0() in C:\Dev\xunit\xunit\src\xunit.execution\Sdk\Frameworks\Runners\TestInvoker.cs:line 206
   at System.Runtime.CompilerServices.AsyncMethodBuilderCore.Start[TStateMachine](TStateMachine& stateMachine)
   at Xunit.Sdk.TestInvoker`1.<RunAsync>b__47_0()
   at Xunit.Sdk.ExceptionAggregator.RunAsync[T](Func`1 code) in C:\Dev\xunit\xunit\src\xunit.core\Sdk\ExceptionAggregator.cs:line 107
   at System.Runtime.CompilerServices.AsyncMethodBuilderCore.Start[TStateMachine](TStateMachine& stateMachine)
   at Xunit.Sdk.ExceptionAggregator.RunAsync[T](Func`1 code)
   at Xunit.Sdk.TestInvoker`1.RunAsync() in C:\Dev\xunit\xunit\src\xunit.execution\Sdk\Frameworks\Runners\TestInvoker.cs:line 189
   at Xunit.Sdk.XunitTestRunner.InvokeTestMethodAsync(ExceptionAggregator aggregator) in C:\Dev\xunit\xunit\src\xunit.execution\Sdk\Frameworks\Runners\XunitTestRunner.cs:line 84
   at Xunit.Sdk.XunitTestRunner.InvokeTestAsync(ExceptionAggregator aggregator) in C:\Dev\xunit\xunit\src\xunit.execution\Sdk\Frameworks\Runners\XunitTestRunner.cs:line 67
   at System.Runtime.CompilerServices.AsyncMethodBuilderCore.Start[TStateMachine](TStateMachine& stateMachine)
   at Xunit.Sdk.XunitTestRunner.InvokeTestAsync(ExceptionAggregator aggregator)
   at Xunit.Sdk.TestRunner`1.<>c__DisplayClass43_0.<RunAsync>b__0() in C:\Dev\xunit\xunit\src\xunit.execution\Sdk\Frameworks\Runners\TestRunner.cs:line 149
   at Xunit.Sdk.ExceptionAggregator.RunAsync[T](Func`1 code) in C:\Dev\xunit\xunit\src\xunit.core\Sdk\ExceptionAggregator.cs:line 107
   at System.Runtime.CompilerServices.AsyncMethodBuilderCore.Start[TStateMachine](TStateMachine& stateMachine)
   at Xunit.Sdk.ExceptionAggregator.RunAsync[T](Func`1 code)
   at Xunit.Sdk.TestRunner`1.RunAsync() in C:\Dev\xunit\xunit\src\xunit.execution\Sdk\Frameworks\Runners\TestRunner.cs:line 149
   at System.Runtime.CompilerServices.AsyncMethodBuilderCore.Start[TStateMachine](TStateMachine& stateMachine)
   at Xunit.Sdk.TestRunner`1.RunAsync()
   at Xunit.Sdk.XunitTheoryTestCaseRunner.RunTestAsync() in C:\Dev\xunit\xunit\src\xunit.execution\Sdk\Frameworks\Runners\XunitTheoryTestCaseRunner.cs:line 144
   at System.Runtime.CompilerServices.AsyncMethodBuilderCore.Start[TStateMachine](TStateMachine& stateMachine)
   at Xunit.Sdk.XunitTheoryTestCaseRunner.RunTestAsync()
   at Xunit.Sdk.TestCaseRunner`1.RunAsync() in C:\Dev\xunit\xunit\src\xunit.execution\Sdk\Frameworks\Runners\TestCaseRunner.cs:line 82
   at System.Runtime.CompilerServices.AsyncMethodBuilderCore.Start[TStateMachine](TStateMachine& stateMachine)
   at Xunit.Sdk.TestCaseRunner`1.RunAsync()
   at Xunit.Sdk.XunitTheoryTestCase.RunAsync(IMessageSink diagnosticMessageSink, IMessageBus messageBus, Object[] constructorArguments, ExceptionAggregator aggregator, CancellationTokenSource cancellationTokenSource) in C:\Dev\xunit\xunit\src\xunit.execution\Sdk\Frameworks\XunitTheoryTestCase.cs:line 51
   at Xunit.Sdk.XunitTestMethodRunner.RunTestCaseAsync(IXunitTestCase testCase) in C:\Dev\xunit\xunit\src\xunit.execution\Sdk\Frameworks\Runners\XunitTestMethodRunner.cs:line 45
   at Xunit.Sdk.TestMethodRunner`1.RunTestCasesAsync() in C:\Dev\xunit\xunit\src\xunit.execution\Sdk\Frameworks\Runners\TestMethodRunner.cs:line 136
   at System.Runtime.CompilerServices.AsyncMethodBuilderCore.Start[TStateMachine](TStateMachine& stateMachine)
   at Xunit.Sdk.TestMethodRunner`1.RunTestCasesAsync()
   at Xunit.Sdk.TestMethodRunner`1.RunAsync() in C:\Dev\xunit\xunit\src\xunit.execution\Sdk\Frameworks\Runners\TestMethodRunner.cs:line 106
   at System.Runtime.CompilerServices.AsyncMethodBuilderCore.Start[TStateMachine](TStateMachine& stateMachine)
   at Xunit.Sdk.TestMethodRunner`1.RunAsync()
   at Xunit.Sdk.XunitTestClassRunner.RunTestMethodAsync(ITestMethod testMethod, IReflectionMethodInfo method, IEnumerable`1 testCases, Object[] constructorArguments) in C:\Dev\xunit\xunit\src\xunit.execution\Sdk\Frameworks\Runners\XunitTestClassRunner.cs:line 168
   at Xunit.Sdk.TestClassRunner`1.RunTestMethodsAsync()
   at System.Runtime.CompilerServices.AsyncMethodBuilderCore.Start[TStateMachine](TStateMachine& stateMachine)
   at Xunit.Sdk.TestClassRunner`1.RunTestMethodsAsync()
   at Xunit.Sdk.TestClassRunner`1.RunAsync() in C:\Dev\xunit\xunit\src\xunit.execution\Sdk\Frameworks\Runners\TestClassRunner.cs:line 171
   at System.Runtime.CompilerServices.AsyncMethodBuilderCore.Start[TStateMachine](TStateMachine& stateMachine)
   at Xunit.Sdk.TestClassRunner`1.RunAsync()
   at Xunit.Sdk.XunitTestCollectionRunner.RunTestClassAsync(ITestClass testClass, IReflectionTypeInfo class, IEnumerable`1 testCases) in C:\Dev\xunit\xunit\src\xunit.execution\Sdk\Frameworks\Runners\XunitTestCollectionRunner.cs:line 158
   at Xunit.Sdk.TestCollectionRunner`1.RunTestClassesAsync()
   at System.Runtime.CompilerServices.AsyncMethodBuilderCore.Start[TStateMachine](TStateMachine& stateMachine)
   at Xunit.Sdk.TestCollectionRunner`1.RunTestClassesAsync()
   at Xunit.Sdk.TestCollectionRunner`1.RunAsync() in C:\Dev\xunit\xunit\src\xunit.execution\Sdk\Frameworks\Runners\TestCollectionRunner.cs:line 101
   at System.Runtime.CompilerServices.AsyncMethodBuilderCore.Start[TStateMachine](TStateMachine& stateMachine)
   at Xunit.Sdk.TestCollectionRunner`1.RunAsync()
   at Xunit.Sdk.XunitTestAssemblyRunner.RunTestCollectionAsync(IMessageBus messageBus, ITestCollection testCollection, IEnumerable`1 testCases, CancellationTokenSource cancellationTokenSource) in C:\Dev\xunit\xunit\src\xunit.execution\Sdk\Frameworks\Runners\XunitTestAssemblyRunner.cs:line 235
   at Xunit.Sdk.XunitTestAssemblyRunner.<>c__DisplayClass14_2.<RunTestCollectionsAsync>b__2() in C:\Dev\xunit\xunit\src\xunit.execution\Sdk\Frameworks\Runners\XunitTestAssemblyRunner.cs:line 184
   at System.Threading.Tasks.Task`1.InnerInvoke()
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
   at System.Threading.Tasks.Task.ExecuteWithThreadLocal(Task& currentTaskSlot, Thread threadPoolThread)
   at System.Threading.Tasks.Task.ExecuteEntry()
   at System.Threading.Tasks.SynchronizationContextTaskScheduler.<>c.<.cctor>b__8_0(Object s)
   at Xunit.Sdk.MaxConcurrencySyncContext.RunOnSyncContext(SendOrPostCallback callback, Object state) in C:\Dev\xunit\xunit\src\xunit.execution\Sdk\MaxConcurrencySyncContext.cs:line 106
   at Xunit.Sdk.MaxConcurrencySyncContext.<>c__DisplayClass11_0.<WorkerThreadProc>b__0(Object _) in C:\Dev\xunit\xunit\src\xunit.execution\Sdk\MaxConcurrencySyncContext.cs:line 96
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
   at Xunit.Sdk.ExecutionContextHelper.Run(Object context, Action`1 action) in C:\Dev\xunit\xunit\src\xunit.execution\Sdk\Utility\ExecutionContextHelper.cs:line 110
   at Xunit.Sdk.MaxConcurrencySyncContext.WorkerThreadProc() in C:\Dev\xunit\xunit\src\xunit.execution\Sdk\MaxConcurrencySyncContext.cs:line 96
   at Xunit.Sdk.XunitWorkerThread.<>c.<.ctor>b__1_0(Object s) in C:\Dev\xunit\xunit\src\common\XunitWorkerThread.cs:line 72
=== COMMAND LINE ===

lindexi · 2023-09-15T00:39:38Z

Awesome

...DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Xaml/Permissions/XamlAccessLevelTests.cs

harshit7962 · 2023-11-23T10:52:41Z

/azp run

azure-pipelines · 2023-11-23T10:52:52Z

Azure Pipelines successfully started running 1 pipeline(s).

hughbe · 2023-11-23T11:14:16Z

Some tests failing due to the change to return [] instead of null here: https://github.com/dotnet/wpf/blob/main/src/Microsoft.DotNet.Wpf/src/System.Xaml/System/Xaml/Replacements/TypeListConverter.cs#L41

#203 (comment)

harshit7962 · 2023-11-24T06:58:07Z

@hughbe the ConvertFrom method should throw a NotSupportedException when the value is null. This was the case previously. Isn't the previous state, checking for the exception, the more correct one?

src/Microsoft.DotNet.Wpf/src/System.Xaml/System/Xaml/InfosetObjects/XamlNodes.cs

src/Microsoft.DotNet.Wpf/src/System.Xaml/System/Xaml/Schema/TypeReflector.cs

rchauhan18

LGTM.
@hughbe
Thanks for your contribution!
Are you planning to add more test?
If not, I can continue to merge it.

hughbe · 2024-07-31T12:40:34Z

I'm not planning to add any more tests :)

Thanks for your review

miloush · 2024-07-31T18:32:03Z

Disclaimer: I haven't gone through the PR. However, I am worried about the asserts being removed, presumably they were added for a reason and express an expectation of the code that follows. Either the tests should be fixed to not hit them or if we think they are unreasonable, the code needs to be checked that it can deal with the conditions being broken.

hughbe · 2024-08-01T08:25:05Z

If there are situations where Debug asserts can be hit by unit tests, I've only ever seen us removing them (and fixing any downstream bugs, e.g., NREs etc.).

ThomasGoulet73 · 2024-09-28T05:14:13Z

@hughbe It seems like the only remaining point of discussion in this PR is about the removal of asserts, would it be easy to extract the tests that requires the removal of asserts and open a separate PR with them ? If so, I think it would be a good idea to do so to be able to merge this PR as soon as possible and the changes in this PR would be less controversial since there would be no non-test changes.

dipeshmsft · 2024-12-16T13:42:42Z

@hughbe, I have looked at the PR and the changes LGTM, however there are two style errors which are causing the issue here : IDE0059 and IDE0073. Can you fix these issues in the PR ?

hughbe · 2024-12-30T11:11:48Z

Apologies for the delay. I have just fixed all the IDE errors and failing tests

dipeshmsft · 2024-12-30T12:02:56Z

Thanks @hughbe, I was just getting started with using the NoAssertContext mentioned in the other pull request. Thanks for fixing this though.

dipeshmsft · 2024-12-30T12:32:57Z

Thanks a lot @hughbe for the PR, and apologies for the delays from our side. I will move on to reviewing the other PR.

hughbe · 2024-12-30T18:20:32Z

Thank you! Really glad this was merged in :)

hughbe requested a review from a team as a code owner September 12, 2023 09:28

ghost assigned hughbe Sep 12, 2023

ghost added the PR metadata: Label to tag PRs, to facilitate with triage label Sep 12, 2023

ghost requested review from dipeshmsft and singhashish-wpf September 12, 2023 09:28

ghost added the Community Contribution A label for all community Contributions label Sep 12, 2023

hughbe force-pushed the system-xaml-tests branch from 30733d2 to 878511f Compare September 12, 2023 13:10

hughbe force-pushed the system-xaml-tests branch 3 times, most recently from 6f117bb to ef3fec1 Compare September 13, 2023 09:08

hughbe force-pushed the system-xaml-tests branch from ef3fec1 to d2a7915 Compare October 5, 2023 08:14

harshit7962 reviewed Oct 16, 2023

View reviewed changes

...DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Xaml/Permissions/XamlAccessLevelTests.cs Outdated Show resolved Hide resolved

hughbe force-pushed the system-xaml-tests branch 2 times, most recently from 409cd6a to 4cdbd16 Compare November 23, 2023 12:57

hughbe force-pushed the system-xaml-tests branch 2 times, most recently from 13a2c4b to 000ec2d Compare April 28, 2024 09:23

hughbe force-pushed the system-xaml-tests branch from 000ec2d to 5147840 Compare July 29, 2024 10:20

hughbe requested a review from a team as a code owner July 29, 2024 10:20

rchauhan18 reviewed Jul 31, 2024

View reviewed changes

src/Microsoft.DotNet.Wpf/src/System.Xaml/System/Xaml/InfosetObjects/XamlNodes.cs Outdated Show resolved Hide resolved

rchauhan18 reviewed Jul 31, 2024

View reviewed changes

src/Microsoft.DotNet.Wpf/src/System.Xaml/System/Xaml/Schema/TypeReflector.cs Outdated Show resolved Hide resolved

rchauhan18 previously approved these changes Jul 31, 2024

View reviewed changes

Add System.Xaml tests

de9940b

hughbe dismissed rchauhan18’s stale review via de9940b December 12, 2024 14:00

hughbe force-pushed the system-xaml-tests branch from 5147840 to de9940b Compare December 12, 2024 14:00

Fix IDE warnings and fix Debug assert tests

afcc0dd

hughbe force-pushed the system-xaml-tests branch from 81a61bb to afcc0dd Compare December 30, 2024 11:11

dipeshmsft approved these changes Dec 30, 2024

View reviewed changes

dipeshmsft merged commit e1babd2 into dotnet:main Dec 30, 2024
8 checks passed

hughbe deleted the system-xaml-tests branch December 30, 2024 18:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add more System.Xaml tests #8203

Add more System.Xaml tests #8203

hughbe commented Sep 12, 2023 •

edited by ghost

Loading

hughbe commented Sep 12, 2023

lindexi commented Sep 15, 2023

harshit7962 commented Nov 23, 2023

azure-pipelines bot commented Nov 23, 2023

hughbe commented Nov 23, 2023

harshit7962 commented Nov 24, 2023

rchauhan18 left a comment

hughbe commented Jul 31, 2024 •

edited

Loading

miloush commented Jul 31, 2024

hughbe commented Aug 1, 2024

ThomasGoulet73 commented Sep 28, 2024

dipeshmsft commented Dec 16, 2024 •

edited

Loading

hughbe commented Dec 30, 2024

dipeshmsft commented Dec 30, 2024

dipeshmsft commented Dec 30, 2024

hughbe commented Dec 30, 2024

Add more System.Xaml tests #8203

Add more System.Xaml tests #8203

Conversation

hughbe commented Sep 12, 2023 • edited by ghost Loading

Microsoft Reviewers: Open in CodeFlow

hughbe commented Sep 12, 2023

lindexi commented Sep 15, 2023

harshit7962 commented Nov 23, 2023

azure-pipelines bot commented Nov 23, 2023

hughbe commented Nov 23, 2023

harshit7962 commented Nov 24, 2023

rchauhan18 left a comment

Choose a reason for hiding this comment

hughbe commented Jul 31, 2024 • edited Loading

miloush commented Jul 31, 2024

hughbe commented Aug 1, 2024

ThomasGoulet73 commented Sep 28, 2024

dipeshmsft commented Dec 16, 2024 • edited Loading

hughbe commented Dec 30, 2024

dipeshmsft commented Dec 30, 2024

dipeshmsft commented Dec 30, 2024

hughbe commented Dec 30, 2024

hughbe commented Sep 12, 2023 •

edited by ghost

Loading

hughbe commented Jul 31, 2024 •

edited

Loading

dipeshmsft commented Dec 16, 2024 •

edited

Loading