Add specs for app/controllers/applications_controller.rb

[cachar]

There's some tricky stuff around applications changing state, and there might be some edge cases. We should add some specs to make sure everything is behaving as expected.

[urbanfog]

I'd like to tackle this as my first 'real' PR.

[compwron]

@urbanfog awesome! It's all yours. Feel free to ask questions, I'd love to help :)

[urbanfog]

Any specific spots in the app you want to me start with?

[brittag]

Hi @urbanfog! I encourage checking out the issues at #295 and #317 as potential side-effects of issues in the state machine. Basically, when people submit applications to become members, occasionally they get an error message about their application. It could be good to inspect that area of the logic. For example, what are all the possible states that an application can be in before it's submitted, and do they transition properly when a person clicks "submit"?

I hope that makes sense - I'm not a programmer, just a member who has used the app a lot. :)

[anaulin]

Unassigned this issue so that it is clearer that it is up for grabs, since there's been no activity for a while. @urbanfog if you still want to work on this, you're very welcome! (Let me know if you need help/support with it.)

[anaulin]

It looks like we already have a decent set of specs for this in https://github.com/doubleunion/arooo/blob/master/spec/controllers/applications_controller_spec.rb . Wondering if there were specific things that this ticket wanted to see tested? (Or maybe this issue is obsolete and we should close it?)