-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
fix: Prevent jump on node selection (no auto scroll to center) #408
Merged
mrchief
merged 7 commits into
dowjones:develop
from
aarce-uncharted:fix/Disable-automatic-scrolling-on-selection
Aug 9, 2020
Merged
fix: Prevent jump on node selection (no auto scroll to center) #408
mrchief
merged 7 commits into
dowjones:develop
from
aarce-uncharted:fix/Disable-automatic-scrolling-on-selection
Aug 9, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarce-uncharted
changed the title
Fix/Disable automatic scrolling on selection
Fix: Disable automatic scrolling on selection
Aug 5, 2020
Pull Request Test Coverage Report for Build 1487
💛 - Coveralls |
mrchief
reviewed
Aug 5, 2020
aarce-uncharted
force-pushed
the
fix/Disable-automatic-scrolling-on-selection
branch
from
August 5, 2020 20:24
d7311d6
to
b83961a
Compare
mrchief
changed the title
Fix: Disable automatic scrolling on selection
fix: Disable automatic scrolling on selection
Aug 6, 2020
mrchief
changed the title
fix: Disable automatic scrolling on selection
fix: Jankiness on node selection (no auto scroll to center)
Aug 6, 2020
mrchief
changed the title
fix: Jankiness on node selection (no auto scroll to center)
fix: jumpy behavior on node selection (no auto scroll to center)
Aug 6, 2020
mrchief
approved these changes
Aug 9, 2020
Code Climate has analyzed commit 3aaf0da and detected 0 issues on this pull request. View more on Code Climate. |
@all-contributors Please add @aarce-uncharted for code |
I've put up a pull request to add @aarce-uncharted! 🎉 |
mrchief
changed the title
fix: jumpy behavior on node selection (no auto scroll to center)
fix: Prevent jump on node selection (no auto scroll to center)
Aug 9, 2020
🎉 This PR is included in version 2.4.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
m4theushw
pushed a commit
to m4theushw/react-dropdown-tree-select
that referenced
this pull request
Sep 20, 2020
…nes#408) Co-authored-by: Hrusikesh Panda <mrchief@users.noreply.github.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Disables automatic scroll on selection.
Fixes # (issue)
Fixes #391
Type of change
Please delete options that are not relevant.
Checklist: