Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: Prevent jump on node selection (no auto scroll to center) #408

Conversation

aarce-uncharted
Copy link
Contributor

@aarce-uncharted aarce-uncharted commented Aug 5, 2020

What does it do?

Disables automatic scroll on selection.

Fixes # (issue)

Fixes #391

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • Updated documentation (if applicable)
  • Added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • My changes generate no new warnings

src/index.js Outdated Show resolved Hide resolved
@aarce-uncharted aarce-uncharted changed the title Fix/Disable automatic scrolling on selection Fix: Disable automatic scrolling on selection Aug 5, 2020
@coveralls
Copy link

coveralls commented Aug 5, 2020

Pull Request Test Coverage Report for Build 1487

  • 4 of 4 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.04%) to 93.965%

Totals Coverage Status
Change from base Build 1486: -0.04%
Covered Lines: 598
Relevant Lines: 619

💛 - Coveralls

@aarce-uncharted aarce-uncharted force-pushed the fix/Disable-automatic-scrolling-on-selection branch from d7311d6 to b83961a Compare August 5, 2020 20:24
@mrchief mrchief changed the title Fix: Disable automatic scrolling on selection fix: Disable automatic scrolling on selection Aug 6, 2020
@mrchief mrchief changed the title fix: Disable automatic scrolling on selection fix: Jankiness on node selection (no auto scroll to center) Aug 6, 2020
@mrchief mrchief changed the title fix: Jankiness on node selection (no auto scroll to center) fix: jumpy behavior on node selection (no auto scroll to center) Aug 6, 2020
@codeclimate
Copy link

codeclimate bot commented Aug 9, 2020

Code Climate has analyzed commit 3aaf0da and detected 0 issues on this pull request.

View more on Code Climate.

@mrchief
Copy link
Collaborator

mrchief commented Aug 9, 2020

@all-contributors Please add @aarce-uncharted for code

@allcontributors
Copy link
Contributor

@mrchief

I've put up a pull request to add @aarce-uncharted! 🎉

@mrchief mrchief changed the title fix: jumpy behavior on node selection (no auto scroll to center) fix: Prevent jump on node selection (no auto scroll to center) Aug 9, 2020
@mrchief mrchief merged commit 8451882 into dowjones:develop Aug 9, 2020
@github-actions
Copy link

github-actions bot commented Aug 9, 2020

🎉 This PR is included in version 2.4.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

m4theushw pushed a commit to m4theushw/react-dropdown-tree-select that referenced this pull request Sep 20, 2020
…nes#408)

Co-authored-by: Hrusikesh Panda <mrchief@users.noreply.github.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable Automatic Scrolling on Selection
3 participants