Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Refactor tests from unittest to pytest #1167

Closed
jeffwidman opened this issue Aug 4, 2017 · 1 comment
Closed

Refactor tests from unittest to pytest #1167

jeffwidman opened this issue Aug 4, 2017 · 1 comment
Labels
test coverage

Comments

@jeffwidman
Copy link
Contributor

For example file that should be migrated (at least part of it):
https://github.com/dpkp/kafka-python/blob/master/test/test_consumer_integration.py

This would let us use more pytest features, such as mentioned here:
#1161 (comment)

Not worth spending the time to do this for tests of old/deprecated code such as SimpleConsumer / SimpleProducer.
@jeffwidman jeffwidman mentioned this issue Aug 4, 2017
Merged
@jeffwidman
Copy link
Contributor Author

This was handled as part of #1193 and related cleanups. We are now fully on pytest.

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
test coverage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jeffwidman @dpkp