Raise AssertionError when decompression unsupported. Fix #1033 #1159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffwidman
changed the title
|
Fix #1033 |
|
+1. Might also be good to raise something other than AssertionError when compression libraries are not available. I believe the source of the exception is in kafka/protocol/message.py decompress() |
|
I agree with @dpkp that we should be raising/catching something more specific than an |
|
Filed #1168 to follow-up |
88manpreet
pushed a commit
to Yelp/kafka-python
that referenced
this pull request
Aug 25, 2017
88manpreet
pushed a commit
to Yelp/kafka-python
that referenced
this pull request
Oct 6, 2017
88manpreet
pushed a commit
to Yelp/kafka-python
that referenced
this pull request
Jul 16, 2018
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raise AssertionError when decompression unsupported.