Remove a few unused imports #1188
Conversation
kafka/client_async.py
Outdated
| @@ -28,8 +28,6 @@ | |||
| from .metrics.stats import Avg, Count, Rate | |||
| from .metrics.stats.rate import TimeUnit | |||
| from .protocol.metadata import MetadataRequest | |||
| from .protocol.produce import ProduceRequest | |||
| from .vendor import socketpair | |||
There was a problem hiding this comment.
This one should be left in, as it monkey-patches socket.socketpair():
kafka-python/kafka/vendor/socketpair.py
Line 58 in ba7afd9
Rather than removing, can you add a comment right above it saying something like:
Although this looks unused, it actually monkey-patches
socket.socketpair()and should be left in as long as we're usingsocket.socketpair()in this file.
There was a problem hiding this comment.
Got it! Yep, I can make that change
kafka/client_async.py
Outdated
| @@ -28,7 +28,9 @@ | |||
| from .metrics.stats import Avg, Count, Rate | |||
| from .metrics.stats.rate import TimeUnit | |||
| from .protocol.metadata import MetadataRequest | |||
| from .protocol.produce import ProduceRequest | |||
|
|
|||
There was a problem hiding this comment.
minor nit: Can you remove this empty line, per PEP-8 style guide?
There was a problem hiding this comment.
ha hey if more people nitpicked about PEP-8 stuff, the world would be a happier and safer place!
I am on it. One moment
|
Thanks! |
* Removed a few unused imports * Added note on socketpair monkey-path
Thank you for creating and maintaining this excellent package! I was reading through the code today just trying to get a better sense of the internals, and found a few unused imports. Please consider this PR to remove them.