Handle lookup_coordinator send failures #1279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wouldn't the Java code hit this? Curious whether there's an upstream Jira ticket... |
jeffwidman
reviewed
Oct 24, 2017
kafka/coordinator/base.py
Outdated
| return self._find_coordinator_future | ||
|
|
||
| # If there is an error sending the group coordinator request | ||
| # then the errback will immediately fire and reset _find_coordinator_future = None |
There was a problem hiding this comment.
should this be _reset_find_coordinator_future?
If you're actually trying to use "reset" as a verb, can you pick a different word as it makes it confusing since both _find_coordinator_future and _reset_find_coordinator_future are used in this block of code...
|
kafka-python does immediate network sends, which exposes futures to immediate failure. Java client uses an asynchronous send queue, so it would not have the same issue. See #981 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1278