Make BrokerConnection .host / .port / .afi immutable #1422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ributes for current lookups
I'm struggling to parse this... should the word "not" be omitted from the above? |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separating this from #1411. The underlying issue is that KafkaClient checks whether the broker metadata has changed when deciding whether to "recycle" an existing BrokerConnection or not (see
_maybe_connect). The check examines .host and .port directly, which means that we are creating false positives when we assign new resolved values to these attributes. This means that we are not recycling BrokerConnection objects the way we want to at best, and at worst it means that we are not dropping the objects before trying all possible resolved connection addresses.