Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Various docstring / pep8 / code hygiene cleanups #1647

Merged
merged 1 commit into from
Nov 19, 2018

Conversation

jeffwidman
Copy link
Contributor

@jeffwidman jeffwidman commented Nov 17, 2018

This is a hodge-podge of changes that crept into my source code while I was working on it.

I figured I'd put them up under a catch-all commit. Putting this up for now as a PR, but it may be better broken out differently. Also, some of these are trivial style nits that may not be worth fixing.

This change is Reviewable

@jeffwidman jeffwidman force-pushed the docstring-pep8-cleanup branch 2 times, most recently from 1e4ac46 to a142038 Compare November 18, 2018 08:53
@jeffwidman
Copy link
Contributor Author

jeffwidman commented Nov 18, 2018

Let's hold off on merging until after the other PRs that I put up against KafkaAdmin get merged and then I will take another look at this...

@jeffwidman jeffwidman force-pushed the docstring-pep8-cleanup branch from a142038 to f53062d Compare November 18, 2018 23:38
@jeffwidman
Copy link
Contributor Author

I looked through all this, and it all still looks like it improves the code/docstrings, so merging.

@jeffwidman jeffwidman merged commit 24f4131 into master Nov 19, 2018
@jeffwidman jeffwidman deleted the docstring-pep8-cleanup branch November 19, 2018 00:47
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant