Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Send pending requests before waiting for responses #1762

Merged
merged 1 commit into from
Mar 27, 2019
Merged

Conversation

dpkp
Copy link
Owner

@dpkp dpkp commented Mar 22, 2019

I don't think it is strictly necessary to send before receiving in the poll loop, but I think the design makes more sense. Leveraging the request-time-out loop was more of an optimization to avoid looping through the connection list twice. In the future we might consider other optimizations, including tracking connections w/ pending data to write and using select to identify which/when those sockets are available for writing.


This change is Reviewable

@dpkp dpkp merged commit e45b89b into master Mar 27, 2019
@dpkp dpkp deleted the send_first_poll branch March 27, 2019 14:45
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants