remove unused imports #2046
Merged
remove unused imports #2046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffwidman
approved these changes
Jun 22, 2020
|
I've rebased this to |
dpkp
approved these changes
Jun 27, 2020
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for this great project!
I wanted to take a few minutes and make a small contribution, so I ran
flake8over this codebase. A lot of the warnings generated are things that should only be done optionally by maintainers (like formatting and whitespace), but I think I found a few non-controversial changes that would be helpful.In this PR, I'd like to propose removing a few unused imports and one local variable that is created but never used in
ScramClient.Thanks for your time and consideration.
This change is