Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm in the process of building a dynamic analysis tool for python, I ran it on this repo and found a potential improvement.
Right now the builtin crc32 module uses
type(data) != array.array
.However, using
not isinstance(data, array.array)
has a number of advantages:array.array
subtypes are supportedI measured the performance as follows:
where
crc_update_faster
usesnot isinstance(data, array.array)
.You can find a more detailed explanation why
isinstance
might be better in this blogpost.This change is