Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Theme doesn't work in the new code editor #15

Open
nevercade opened this issue Dec 17, 2024 · 5 comments
Open

Theme doesn't work in the new code editor #15

nevercade opened this issue Dec 17, 2024 · 5 comments

Comments

@nevercade
Copy link

image
It looks like sadly the theme colours aren't carried over into the new version of the code editor and some UI elements. :(

@tonystr
Copy link
Contributor

tonystr commented Dec 18, 2024

Thank you for reporting.

This will likely require some more work to fix, but I am not familiar with the new gamemaker UI changes. If someone else would like to update the colors for the new UI, I would be happy to review changes and merge

@tabularelf
Copy link

tabularelf commented Dec 19, 2024

This was due part to CE2 having it's own theme system from the complete work up. This isn't so much as a simple "existing GameMaker theme", it's a completely separate theme system, tied with the new code editor. I don't think this can be remedied by just merging with the existing theme system.

Fortunately, a user from the GameMaker Discord, @backYard321, has already gone ahead and prepared a version matching the colours. I haven't thoroughly tested this (as I've been busy doing other things), but this should be a good base to start.
Edit: Redacted link as backYard has posted an update to date version
image

@backYard321
Copy link

backYard321 commented Dec 19, 2024

A few things to note before circulating this new file:

  1. I've opted to recreate the CE1 highlighting more faithfully, HOWEVER as a result, this theme doesn't take advantage of certain CE2 highlighting functionality (bolded highlighting for keywords like return, different highlighting for escape characters in strings, user functions VS built-in functions, etc). This should probably be changed.
  2. There are likely inconsistencies here - this was really just a rough first pass. For example: I ROUGHLY eyeballed the code highlighting colour - in my previous version it actually DARKENED the highlighted area.
  3. There are many highlighting "scopes" that i left as their default, rather than using the Dracula palette, as I'm generally ignorant of how Dracula highlights these outside of Gamemaker. These should all be redone according to how Dracula typically colours them.

TLDR: my version is rough, and needs more fixes before circulating

Here's my current version:
Dracula.zip

@tonystr
Copy link
Contributor

tonystr commented Dec 19, 2024

Thank you for making this, this makes it a lot easier. Do you know if this can be included in the repo and gamemaker will automatically apply the theme colors when selecting the dracula theme? Or will users have to select this separately?

@backYard321
Copy link

Unfortunately it's separate - the CE2 colour themes are stored separately in the user's roaming appdata folder.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Development

No branches or pull requests

4 participants