Skip to content

Commit 4d89d63

Browse files
authoredMar 5, 2022
Merge pull request #21 from drazisil/1.2.1
fix: remove depreciated uri.escape, bump version
2 parents 4a6182b + a09e486 commit 4d89d63

File tree

5 files changed

+36
-33
lines changed

5 files changed

+36
-33
lines changed
 

‎.github/workflows/main.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ jobs:
1010
- name: Clone repo
1111
uses: actions/checkout@v2
1212

13-
- uses: actions/setup-ruby@v1
13+
- uses: ruby/setup-ruby@v1.99.0
1414
with:
1515
ruby-version: '2.6' # Version range or exact version of a Ruby version to use, using semvers version range syntax.
1616

‎Gemfile.lock

+25-28
Original file line numberDiff line numberDiff line change
@@ -7,45 +7,42 @@ PATH
77
GEM
88
remote: https://rubygems.org/
99
specs:
10-
codecov (0.1.10)
10+
codecov (0.1.21)
1111
json
1212
simplecov
13-
url
14-
diff-lcs (1.3)
15-
docile (1.1.5)
13+
diff-lcs (1.5.0)
14+
docile (1.4.0)
1615
hpricot (0.8.6)
1716
json (2.3.0)
18-
multi_json (1.12.2)
19-
mustache (1.0.5)
20-
pygments.rb (1.2.0)
21-
multi_json (>= 1.0.0)
22-
rake (12.1.0)
23-
rdiscount (2.2.0.1)
17+
mustache (1.1.1)
18+
pygments.rb (2.3.0)
19+
rake (13.0.6)
20+
rdiscount (2.2.0.2)
2421
ronn (0.7.3)
2522
hpricot (>= 0.8.2)
2623
mustache (>= 0.7.0)
2724
rdiscount (>= 1.5.8)
28-
rspec (3.6.0)
29-
rspec-core (~> 3.6.0)
30-
rspec-expectations (~> 3.6.0)
31-
rspec-mocks (~> 3.6.0)
32-
rspec-core (3.6.0)
33-
rspec-support (~> 3.6.0)
34-
rspec-expectations (3.6.0)
25+
rspec (3.11.0)
26+
rspec-core (~> 3.11.0)
27+
rspec-expectations (~> 3.11.0)
28+
rspec-mocks (~> 3.11.0)
29+
rspec-core (3.11.0)
30+
rspec-support (~> 3.11.0)
31+
rspec-expectations (3.11.0)
3532
diff-lcs (>= 1.2.0, < 2.0)
36-
rspec-support (~> 3.6.0)
37-
rspec-mocks (3.6.0)
33+
rspec-support (~> 3.11.0)
34+
rspec-mocks (3.11.0)
3835
diff-lcs (>= 1.2.0, < 2.0)
39-
rspec-support (~> 3.6.0)
40-
rspec-support (3.6.0)
36+
rspec-support (~> 3.11.0)
37+
rspec-support (3.11.0)
4138
rspec_junit_formatter (0.3.0)
4239
rspec-core (>= 2, < 4, != 2.12.0)
43-
simplecov (0.15.1)
44-
docile (~> 1.1.0)
45-
json (>= 1.8, < 3)
46-
simplecov-html (~> 0.10.0)
47-
simplecov-html (0.10.2)
48-
url (0.3.2)
40+
simplecov (0.21.2)
41+
docile (~> 1.1)
42+
simplecov-html (~> 0.11)
43+
simplecov_json_formatter (~> 0.1)
44+
simplecov-html (0.12.3)
45+
simplecov_json_formatter (0.1.4)
4946

5047
PLATFORMS
5148
ruby
@@ -60,4 +57,4 @@ DEPENDENCIES
6057
rspec_junit_formatter (~> 0.3.0)
6158

6259
BUNDLED WITH
63-
1.15.4
60+
2.2.16

‎ghi

+5-2
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ module GHI
55
module Version
66
MAJOR = 1
77
MINOR = 2
8-
PATCH = 0
8+
PATCH = 1
99
PRE = nil
1010

1111
VERSION = [MAJOR, MINOR, PATCH, PRE].compact.join '.'
@@ -1359,7 +1359,10 @@ module GHI
13591359
def request method, path, options
13601360
path = "/api/v3#{path}" if HOST != DEFAULT_HOST
13611361

1362-
path = URI.escape path
1362+
# puts "\n 1#{path}\n"
1363+
# path = CGI.escape path
1364+
# puts "\n 2#{path}\n"
1365+
13631366
if params = options[:params] and !params.empty?
13641367
q = params.map { |k, v| "#{CGI.escape k.to_s}=#{CGI.escape v.to_s}" }
13651368
path += "?#{q.join '&'}"

‎lib/ghi/client.rb

+4-1
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,10 @@ def delete path, options = {}
9797
def request method, path, options
9898
path = "/api/v3#{path}" if HOST != DEFAULT_HOST
9999

100-
path = URI.escape path
100+
# puts "\n 1#{path}\n"
101+
# path = CGI.escape path
102+
# puts "\n 2#{path}\n"
103+
101104
if params = options[:params] and !params.empty?
102105
q = params.map { |k, v| "#{CGI.escape k.to_s}=#{CGI.escape v.to_s}" }
103106
path += "?#{q.join '&'}"

‎lib/ghi/commands/version.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ module Commands
33
module Version
44
MAJOR = 1
55
MINOR = 2
6-
PATCH = 0
6+
PATCH = 1
77
PRE = nil
88

99
VERSION = [MAJOR, MINOR, PATCH, PRE].compact.join '.'

0 commit comments

Comments
 (0)