Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix PubsubClient #80

Closed
jordy25519 opened this issue Nov 29, 2024 · 0 comments · Fixed by #82
Closed

Fix PubsubClient #80

jordy25519 opened this issue Nov 29, 2024 · 0 comments · Fixed by #82

Comments

@jordy25519
Copy link
Collaborator

The pubsub client provided by solana/agave crates fails silently: https://github.com/anza-xyz/agave/blob/79c0fe5c7cfc94e921a104c4e51e2e27aee9d821/pubsub-client/src/nonblocking/pubsub_client.rs#L489
It also does not provide any method to handle disconnection events.

To work around this drift-rs eagerly initializes new PubSubClient instances when a disconnect is detected.

  1. Its not clear that all disconnects are being detected properly
  2. each instance of PubSubClient creates its own Ws connection with various overhead such as ping messages, etc.

Ideally, drift-rs would multiplex a minimal number of Ws Connections and handle the disconnections properly

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant