Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Parallel support? #24

Open
V-Z opened this issue Jun 29, 2020 · 7 comments
Open

Parallel support? #24

V-Z opened this issue Jun 29, 2020 · 7 comments

Comments

@V-Z
Copy link

V-Z commented Jun 29, 2020

I wonder if there could be any way to parallelize computing of the distances. This would be extremely useful especially for large data sets. Just a small enhancement suggestion. :-)

@HajkD
Copy link
Member

HajkD commented Jun 29, 2020

Sure :) This is on my agenda and I will try to get this done once I have a longer stretch of time for coding. Do you have any suggestion on how to best approach this or is this only a general feature request?

@V-Z
Copy link
Author

V-Z commented Jun 30, 2020

Cool :-) My experience with Rcpp/C++ is exactly zero, so I'm not sure how helpful I can be here... :-( I always did all my needed parallelization with the parallel package - parLapply and relatives. This use to be straightforward, but doesn't work on Windows (I'm Linux-only). If I look at Your code correctly, I think it should be possible to rewrite the for loop(s) in DistMatrixNoUnit.R using parLapply or so.

@HajkD
Copy link
Member

HajkD commented Jul 1, 2020

Perfect, I will look into this!

@fedemolina
Copy link

Hello! Here is an example of parallelizing the calculation of distances between matrices with c ++ using RcppParallel https://gallery.rcpp.org/articles/parallel-distance-matrix/

@HajkD
Copy link
Member

HajkD commented Feb 22, 2021

Hi Federico,

Very cool! Thank you very much for sharing this!

I hope I can find some developer time in the near future to get this implemented.

Many thanks,
Hajk

@fedemolina
Copy link

I started learning c ++ very recently, maybe (if you agree) I could try to implement some distances to practice c ++. I am not an expert by any means and I don't have much time, but I could give it a try.

@HajkD
Copy link
Member

HajkD commented Feb 23, 2021

Sure! Having some working examples would be great. I would also look over the code and there is no rush!

Thank you very much for your help with this!

Cheers,
Hajk

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

3 participants