Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Extra headers not passed correctly to puppeteer #45

Closed
arnoo opened this issue Dec 19, 2024 · 2 comments · Fixed by #47
Closed

Extra headers not passed correctly to puppeteer #45

arnoo opened this issue Dec 19, 2024 · 2 comments · Fixed by #47

Comments

@arnoo
Copy link

arnoo commented Dec 19, 2024

Hello,

It looks like extra headers are not passed correctly to puppeteer, as an assertion that the value is a string fails.

Screenshot_20241219_175655
@drudge drudge linked a pull request Dec 19, 2024 that will close this issue
fix(options): Fix extra headers object structure #47
Merged
@drudge
Copy link
Owner

drudge commented Dec 19, 2024

This is resolved in v1.3.0 which was just published to npm.

@arnoo
Copy link
Author

arnoo commented Dec 20, 2024

Thanks a lot !

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(options): Fix extra headers object structure drudge/n8n-nodes-puppeteer
2 participants
@drudge @arnoo